Fix some views unittests on desktop Linux.

Fix some views unittests on desktop Linux.

BUG=369289
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274369

[Evan Stade, 2014-05-23 01:36:26]

This makes the tests pass (or skips them) on my xmonad setup.

[Evan Stade, 2014-05-23 01:38:10]

On 2014/05/23 01:36:26, Evan Stade wrote:
> This makes the tests pass (or skips them) on my xmonad setup.

whereas before the tests would hang, now they all complete with just 3 failures
remaining:

3 tests failed:
    TooltipControllerCaptureTest.CloseOnCaptureLost
    WidgetTest.TestViewWidthAfterMinimizingWidget
    WidgetTest.WindowMouseModalityTest

[Daniel Erat, 2014-05-23 14:53:58]

lgtm

https://codereview.chromium.org/291093012/diff/40001/ui/views/widget/desktop_...
File ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
(right):

https://codereview.chromium.org/291093012/diff/40001/ui/views/widget/desktop_...
ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc:71: //
Verifies that the AURA windows making up a widget instance have the correct
nit: s/AURA/Aura/

[Evan Stade, 2014-05-23 15:30:31]

https://codereview.chromium.org/291093012/diff/40001/ui/views/widget/desktop_...
File ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
(right):

https://codereview.chromium.org/291093012/diff/40001/ui/views/widget/desktop_...
ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc:71: //
Verifies that the AURA windows making up a widget instance have the correct
On 2014/05/23 14:53:59, Daniel Erat wrote:
> nit: s/AURA/Aura/

oh whoops, I meant to remove this test which is a duplicate of the above.

[Evan Stade, 2014-05-23 17:03:18]

+sky for OWNER review of desktop_native_widget_aura_unittest.cc

[Elliot Glaysher, 2014-05-23 17:26:05]

lgtm

[sky, 2014-05-23 20:05:20]

LGTM

https://codereview.chromium.org/291093012/diff/60001/ui/views/widget/desktop_...
File ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
(right):

https://codereview.chromium.org/291093012/diff/60001/ui/views/widget/desktop_...
ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc:40: #if
defined(OS_LINUX) && !defined(OS_CHROMEOS)
You can remove the chromeos part here since the desktop classes aren't built
there.

https://codereview.chromium.org/291093012/diff/60001/ui/views/widget/desktop_...
ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc:41:
Widget::InitParams init_params =
Should we go for popup everywhere?

[Evan Stade, 2014-05-23 20:08:15]

https://codereview.chromium.org/291093012/diff/60001/ui/views/widget/desktop_...
File ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
(right):

https://codereview.chromium.org/291093012/diff/60001/ui/views/widget/desktop_...
ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc:41:
Widget::InitParams init_params =
On 2014/05/23 20:05:21, sky wrote:
> Should we go for popup everywhere?

I don't know enough to know what's best, so I went for the minimal difference. I
can see the logic in keeping it the same everywhere if you think that's better.

[sky, 2014-05-23 20:22:09]

Go with how you have it.

[Evan Stade, 2014-05-23 21:06:00]

https://codereview.chromium.org/291093012/diff/60001/ui/views/widget/desktop_...
File ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
(right):

https://codereview.chromium.org/291093012/diff/60001/ui/views/widget/desktop_...
ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc:40: #if
defined(OS_LINUX) && !defined(OS_CHROMEOS)
On 2014/05/23 20:05:21, sky wrote:
> You can remove the chromeos part here since the desktop classes aren't built
> there.

Done.

[Evan Stade, 2014-05-23 21:06:27]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-05-23 21:07:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/estade@chromium.org/291093012/80001

[commit-bot: I haz the power, 2014-05-24 01:18:48]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-24 02:11:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-24 02:11:28]

Try jobs failed on following builders:
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)

[Evan Stade, 2014-05-31 01:02:46]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-05-31 01:05:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/estade@chromium.org/291093012/80001

[commit-bot: I haz the power, 2014-05-31 05:30:57]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)

[commit-bot: I haz the power, 2014-05-31 06:16:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-31 06:16:39]

Try jobs failed on following builders:
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)

[Evan Stade, 2014-06-02 18:27:50]

had to add a UI_BASE_EXPORT to GetAtom, still LG to you guys?

[sky, 2014-06-02 19:19:53]

SLGTM

[Evan Stade, 2014-06-02 19:28:00]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-06-02 19:28:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/estade@chromium.org/291093012/100001

[commit-bot: I haz the power, 2014-06-02 23:42:16]

Change committed as 274369