Issue 291093008: cc: Prevent tiles that are required for activation from being placed in NEVER_BIN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 291093008: cc: Prevent tiles that are required for activation from being placed in NEVER_BIN. (Closed)

Created:
6 years, 7 months ago by reveman

Modified:
6 years, 7 months ago

Reviewers:
vmpstr, enne (OOO)

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Prevent tiles that are required for activation from being placed in NEVER_BIN. Some tiles that are required for activation might never be initialized because we move them into EVENTUALLY_BIN before making adjustments based on the memory policy. This is because EVENTUALLY_BIN will map to NEVER_BIN when ALLOW_PREPAINT_ONLY or ALLOW_ABSOLUTE_MINIMUM is the current memory policy. This is fixed by moving low-res tiles into EVENTUALLY_BIN after making adjustments based on current memory policy. BUG=375801 TEST=cc_unittests --gtest_filter=TileManagerTests/TileManagerTest.EnoughMemoryPendingLowResAllowAbsoluteMinimum/* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272077

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -11 lines)			Patch
M	cc/resources/tile_manager.cc	View	4 chunks	+14 lines, -11 lines	0 comments	Download
M	cc/resources/tile_manager_unittest.cc	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	cc/test/test_tile_priorities.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	cc/test/test_tile_priorities.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

reveman

Need this to land before https://codereview.chromium.org/287643004/

6 years, 7 months ago (2014-05-21 16:46:27 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/291093008/1

6 years, 7 months ago (2014-05-21 19:58:57 UTC) #4

Message was sent while issue was closed.

Change committed as 272077

Expand Messages | Collapse Messages