Issue 291093007: Fixed writing json into HTTP response of GCD prototype.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 291093007: Fixed writing json into HTTP response of GCD prototype. (Closed)

Created:
6 years, 7 months ago by Vitaly Buka (NO REVIEWS)

Modified:
6 years, 7 months ago

Reviewers:
Noam Samuel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed writing json into HTTP response of GCD prototype. TBR=noamsml NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271857

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
	M	components/cloud_devices/tools/prototype/prototype.py	View		5 chunks	+11 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Vitaly Buka (NO REVIEWS)

The CQ bit was checked by vitalybuka@chromium.org

6 years, 7 months ago (2014-05-21 02:12:43 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/291093007/1

6 years, 7 months ago (2014-05-21 02:14:46 UTC) #3

Noam Samuel

On 2014/05/21 03:57:06, I haz the power (commit-bot) wrote: > Change committed as 271857 lgtm ...

6 years, 7 months ago (2014-05-21 17:03:55 UTC) #5

Vitaly Buka (NO REVIEWS)

6 years, 7 months ago (2014-05-21 17:08:49 UTC) #6

Message was sent while issue was closed.

On 2014/05/21 17:03:55, Noam Samuel wrote:
> On 2014/05/21 03:57:06, I haz the power (commit-bot) wrote:
> > Change committed as 271857
> 
> lgtm
> 
> I should probably go through and cull items that no longer match the spec. I
> think /privet/public/info doesn't exist anymore.

don't worry if you don't use this part of script.
just update as we go

Expand Messages | Collapse Messages