Issue 291093006: Factor out public/private sources from content .gypis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 291093006: Factor out public/private sources from content .gypis. (Closed)

Created:
6 years, 7 months ago by brettw

Modified:
6 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Factor out public/private sources from content .gypis. This is so these file lists can be shared with the GN build. There should be no change for the GYP build. TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271912

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2092 lines, -2068 lines)			Patch
M	content/content_browser.gypi	View	1 2 3	1 chunk	+1356 lines, -1348 lines	0 comments	Download
M	content/content_child.gypi	View	1 2	1 chunk	+213 lines, -205 lines	0 comments	Download
M	content/content_renderer.gypi	View		1 chunk	+523 lines, -515 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/291093006/60001

6 years, 7 months ago (2014-05-21 06:51:19 UTC) #3

brettw

Committed patchset #4 manually as r271912 (presubmit successful).

6 years, 7 months ago (2014-05-21 16:32:30 UTC) #4

Message was sent while issue was closed.

lgtm