Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: net/ssl/ssl_cipher_suite_names_unittest.cc

Issue 291093002: Fail the SPDY transaction if it does not meet TLS base requirements. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/ssl/ssl_cipher_suite_names_unittest.cc
diff --git a/net/ssl/ssl_cipher_suite_names_unittest.cc b/net/ssl/ssl_cipher_suite_names_unittest.cc
index a9133fb67ea2ea729af607c6fe0e6797148011f3..d2c50637fcde46b3b00f61270d9f9b789d851437 100644
--- a/net/ssl/ssl_cipher_suite_names_unittest.cc
+++ b/net/ssl/ssl_cipher_suite_names_unittest.cc
@@ -56,6 +56,22 @@ TEST(CipherSuiteNamesTest, ParseSSLCipherStringFails) {
}
}
+TEST(CipherSuiteNamesTest, ModernCipherSuites) {
+ // Picked some random cipher suites.
+ EXPECT_FALSE(IsModernTLSCipherSuite(0x0));
+ EXPECT_FALSE(IsModernTLSCipherSuite(0x39));
+ EXPECT_FALSE(IsModernTLSCipherSuite(0xc5));
+ EXPECT_FALSE(IsModernTLSCipherSuite(0xc00f));
+ EXPECT_FALSE(IsModernTLSCipherSuite(0xc083));
+
+ // Non-existent cipher suite.
+ EXPECT_FALSE(IsModernTLSCipherSuite(0xffff)) << "Doesn't exist!";
+
+ // Modern ones.
+ EXPECT_TRUE(IsModernTLSCipherSuite(0xcc13));
+ EXPECT_TRUE(IsModernTLSCipherSuite(0xcc14));
+}
+
} // anonymous namespace
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698