Fail the SPDY transaction if it does not meet TLS base requirements.

net/ssl/ssl_cipher_suite_names.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/ssl/ssl_cipher_suite_names.h"
 
 #include <stdlib.h>
 
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 327 matching lines @@
   int value = 0;
   if (cipher_string.size() == 6 &&
       StartsWithASCII(cipher_string, "0x", false /* case insensitive */) &&
       base::HexStringToInt(cipher_string, &value)) {
     *cipher_suite = static_cast<uint16>(value);
     return true;
   }
   return false;
 }
 
+bool IsModernTLSCipherSuite(uint16 cipher_suite) {
+  struct CipherSuite desired = {0};

[wtc, 2014/05/21 21:51:10]

Nit: I know you copied this from existing code, but since this is a C++ file, we
don't need 'struct' here.

[willchan no longer on Chromium, 2014/05/21 22:55:22]

Done.

+  desired.cipher_suite = cipher_suite;
+
+  void* r = bsearch(&desired,
+                    kCipherSuites,
+                    arraysize(kCipherSuites),
+                    sizeof(kCipherSuites[0]),
+                    CipherSuiteCmp);

[wtc, 2014/05/21 21:51:10]

Nit: just wondering why this is formatted in a different way from the original
code at lines 286-288. Is this formatted by clang?

[willchan no longer on Chromium, 2014/05/21 22:55:22]

Yes.

+
+  if (!r)
+    return false;
+
+  const CipherSuite* cs = static_cast<const CipherSuite*>(r);
+
+  const int key_exchange = cs->encoded >> 8;
+  const int cipher = (cs->encoded >> 3) & 0x1f;
+  const int mac = cs->encoded & 0x7;
+
+  // Only allow forward secure key exchanges.
+  switch (key_exchange) {
+    case 10:  // DHE_RSA

[wtc, 2014/05/21 21:51:10]

Why do you not allow 8 (DHE_DSS)?

[willchan no longer on Chromium, 2014/05/21 22:55:22]

agl@ tells me no one uses DSS.

+    case 14:  // ECDHE_ECDSA
+    case 16:  // ECDHE_RSA
+      break;
+    default:
+      return false;
+  }
+
+  switch (cipher) {
+    case 13:  // AES_128_GCM
+    case 14:  // AES_256_GCM
+    case 17:  // CHACHA20_POLY1305
+      break;
+    default:
+      return false;
+  }
+
+  // Only AEADs allowed.
+  if (mac != kAEADMACValue)
+    return false;
+
+  return true;
+}
+
 }  // namespace net