Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Side by Side Diff: chrome/browser/extensions/api/browsing_data/browsing_data_test.cc

Issue 2910923002: Define DATA_TYPE_SITE_DATA in terms of DATA_TYPE_DOM_STORAGE. (Closed)
Patch Set: Added tests. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <memory> 5 #include <memory>
6 #include <string> 6 #include <string>
7 7
8 #include "base/json/json_string_value_serializer.h" 8 #include "base/json/json_string_value_serializer.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/strings/pattern.h" 10 #include "base/strings/pattern.h"
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 297
298 IN_PROC_BROWSER_TEST_F(ExtensionBrowsingDataTest, RemoveBrowsingDataAll) { 298 IN_PROC_BROWSER_TEST_F(ExtensionBrowsingDataTest, RemoveBrowsingDataAll) {
299 scoped_refptr<BrowsingDataRemoveFunction> function = 299 scoped_refptr<BrowsingDataRemoveFunction> function =
300 new BrowsingDataRemoveFunction(); 300 new BrowsingDataRemoveFunction();
301 EXPECT_EQ(NULL, RunFunctionAndReturnSingleResult(function.get(), 301 EXPECT_EQ(NULL, RunFunctionAndReturnSingleResult(function.get(),
302 kRemoveEverythingArguments, 302 kRemoveEverythingArguments,
303 browser())); 303 browser()));
304 304
305 EXPECT_EQ(base::Time::FromDoubleT(1.0), GetBeginTime()); 305 EXPECT_EQ(base::Time::FromDoubleT(1.0), GetBeginTime());
306 EXPECT_EQ( 306 EXPECT_EQ(
307 (ChromeBrowsingDataRemoverDelegate::DATA_TYPE_SITE_DATA | 307 // TODO(benwells): implement clearing of site usage data via the
308 content::BrowsingDataRemover::DATA_TYPE_CACHE | 308 // browsing data API. https://crbug.com/500801.
309 content::BrowsingDataRemover::DATA_TYPE_DOWNLOADS | 309 // TODO(dmurph): implement clearing of durable storage permission
310 ChromeBrowsingDataRemoverDelegate::DATA_TYPE_FORM_DATA | 310 // via the browsing data API. https://crbug.com/500801.
311 ChromeBrowsingDataRemoverDelegate::DATA_TYPE_HISTORY | 311 // TODO(ramyasharma): implement clearing of external protocol data
312 ChromeBrowsingDataRemoverDelegate::DATA_TYPE_PASSWORDS) & 312 // via the browsing data API. https://crbug.com/692850.
313 // TODO(benwells): implement clearing of site usage data via the 313 content::BrowsingDataRemover::DATA_TYPE_COOKIES |
314 // browsing data API. https://crbug.com/500801. 314 content::BrowsingDataRemover::DATA_TYPE_CHANNEL_IDS |
315 ~ChromeBrowsingDataRemoverDelegate::DATA_TYPE_SITE_USAGE_DATA & 315 (content::BrowsingDataRemover::DATA_TYPE_DOM_STORAGE &
316 // TODO(dmurph): implement clearing of durable storage permission 316 ~content::BrowsingDataRemover::DATA_TYPE_EMBEDDER_DOM_STORAGE) |
317 // via the browsing data API. https://crbug.com/500801. 317 content::BrowsingDataRemover::DATA_TYPE_CACHE |
318 ~ChromeBrowsingDataRemoverDelegate::DATA_TYPE_DURABLE_PERMISSION & 318 content::BrowsingDataRemover::DATA_TYPE_DOWNLOADS |
319 // We can't remove plugin data inside a test profile. 319 ChromeBrowsingDataRemoverDelegate::DATA_TYPE_FORM_DATA |
320 ~ChromeBrowsingDataRemoverDelegate::DATA_TYPE_PLUGIN_DATA & 320 ChromeBrowsingDataRemoverDelegate::DATA_TYPE_HISTORY |
321 // TODO(ramyasharma): implement clearing of external protocol data 321 ChromeBrowsingDataRemoverDelegate::DATA_TYPE_PASSWORDS,
322 // via the browsing data API. https://crbug.com/692850.
323 ~ChromeBrowsingDataRemoverDelegate::DATA_TYPE_EXTERNAL_PROTOCOL_DATA,
324 GetRemovalMask()); 322 GetRemovalMask());
325 } 323 }
326 324
327 IN_PROC_BROWSER_TEST_F(ExtensionBrowsingDataTest, BrowsingDataOriginTypeMask) { 325 IN_PROC_BROWSER_TEST_F(ExtensionBrowsingDataTest, BrowsingDataOriginTypeMask) {
328 RunBrowsingDataRemoveFunctionAndCompareOriginTypeMask("{}", 0); 326 RunBrowsingDataRemoveFunctionAndCompareOriginTypeMask("{}", 0);
329 327
330 RunBrowsingDataRemoveFunctionAndCompareOriginTypeMask( 328 RunBrowsingDataRemoveFunctionAndCompareOriginTypeMask(
331 "{\"unprotectedWeb\": true}", UNPROTECTED_WEB); 329 "{\"unprotectedWeb\": true}", UNPROTECTED_WEB);
332 RunBrowsingDataRemoveFunctionAndCompareOriginTypeMask( 330 RunBrowsingDataRemoveFunctionAndCompareOriginTypeMask(
333 "{\"protectedWeb\": true}", PROTECTED_WEB); 331 "{\"protectedWeb\": true}", PROTECTED_WEB);
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
495 SetPrefsAndVerifySettings(content::BrowsingDataRemover::DATA_TYPE_DOWNLOADS, 493 SetPrefsAndVerifySettings(content::BrowsingDataRemover::DATA_TYPE_DOWNLOADS,
496 0, 494 0,
497 content::BrowsingDataRemover::DATA_TYPE_DOWNLOADS); 495 content::BrowsingDataRemover::DATA_TYPE_DOWNLOADS);
498 SetPrefsAndVerifySettings( 496 SetPrefsAndVerifySettings(
499 ChromeBrowsingDataRemoverDelegate::DATA_TYPE_PASSWORDS, 0, 497 ChromeBrowsingDataRemoverDelegate::DATA_TYPE_PASSWORDS, 0,
500 ChromeBrowsingDataRemoverDelegate::DATA_TYPE_PASSWORDS); 498 ChromeBrowsingDataRemoverDelegate::DATA_TYPE_PASSWORDS);
501 } 499 }
502 500
503 // Test cookie and app data settings. 501 // Test cookie and app data settings.
504 IN_PROC_BROWSER_TEST_F(ExtensionBrowsingDataTest, SettingsFunctionSiteData) { 502 IN_PROC_BROWSER_TEST_F(ExtensionBrowsingDataTest, SettingsFunctionSiteData) {
505 int site_data_no_durable_or_usage_or_external = 503 int supported_site_data_except_plugins =
506 ChromeBrowsingDataRemoverDelegate::DATA_TYPE_SITE_DATA & 504 (content::BrowsingDataRemover::DATA_TYPE_COOKIES |
507 ~ChromeBrowsingDataRemoverDelegate::DATA_TYPE_SITE_USAGE_DATA & 505 content::BrowsingDataRemover::DATA_TYPE_CHANNEL_IDS |
508 ~ChromeBrowsingDataRemoverDelegate::DATA_TYPE_DURABLE_PERMISSION & 506 content::BrowsingDataRemover::DATA_TYPE_DOM_STORAGE) &
509 ~ChromeBrowsingDataRemoverDelegate::DATA_TYPE_EXTERNAL_PROTOCOL_DATA; 507 ~content::BrowsingDataRemover::DATA_TYPE_EMBEDDER_DOM_STORAGE;
510 int site_data_no_plugins_durable_usage_external = 508 int supported_site_data =
511 site_data_no_durable_or_usage_or_external & 509 supported_site_data_except_plugins |
512 ~ChromeBrowsingDataRemoverDelegate::DATA_TYPE_PLUGIN_DATA; 510 ChromeBrowsingDataRemoverDelegate::DATA_TYPE_PLUGIN_DATA;
513 511
514 SetPrefsAndVerifySettings(content::BrowsingDataRemover::DATA_TYPE_COOKIES, 512 SetPrefsAndVerifySettings(content::BrowsingDataRemover::DATA_TYPE_COOKIES,
515 UNPROTECTED_WEB, 513 UNPROTECTED_WEB,
516 site_data_no_plugins_durable_usage_external); 514 supported_site_data_except_plugins);
517 SetPrefsAndVerifySettings( 515 SetPrefsAndVerifySettings(
518 ChromeBrowsingDataRemoverDelegate::DATA_TYPE_HOSTED_APP_DATA_TEST_ONLY, 516 ChromeBrowsingDataRemoverDelegate::DATA_TYPE_HOSTED_APP_DATA_TEST_ONLY,
519 PROTECTED_WEB, site_data_no_plugins_durable_usage_external); 517 PROTECTED_WEB, supported_site_data_except_plugins);
520 SetPrefsAndVerifySettings(content::BrowsingDataRemover::DATA_TYPE_COOKIES | 518 SetPrefsAndVerifySettings(content::BrowsingDataRemover::DATA_TYPE_COOKIES |
521 ChromeBrowsingDataRemoverDelegate:: 519 ChromeBrowsingDataRemoverDelegate::
522 DATA_TYPE_HOSTED_APP_DATA_TEST_ONLY, 520 DATA_TYPE_HOSTED_APP_DATA_TEST_ONLY,
523 PROTECTED_WEB | UNPROTECTED_WEB, 521 PROTECTED_WEB | UNPROTECTED_WEB,
524 site_data_no_plugins_durable_usage_external); 522 supported_site_data_except_plugins);
525 SetPrefsAndVerifySettings( 523 SetPrefsAndVerifySettings(
526 content::BrowsingDataRemover::DATA_TYPE_COOKIES | 524 content::BrowsingDataRemover::DATA_TYPE_COOKIES |
527 ChromeBrowsingDataRemoverDelegate::DATA_TYPE_PLUGIN_DATA, 525 ChromeBrowsingDataRemoverDelegate::DATA_TYPE_PLUGIN_DATA,
528 UNPROTECTED_WEB, site_data_no_durable_or_usage_or_external); 526 UNPROTECTED_WEB, supported_site_data);
529 } 527 }
530 528
531 // Test an arbitrary assortment of settings. 529 // Test an arbitrary assortment of settings.
532 IN_PROC_BROWSER_TEST_F(ExtensionBrowsingDataTest, SettingsFunctionAssorted) { 530 IN_PROC_BROWSER_TEST_F(ExtensionBrowsingDataTest, SettingsFunctionAssorted) {
533 int site_data_no_plugins_durable_usage_external = 531 int supported_site_data =
534 ChromeBrowsingDataRemoverDelegate::DATA_TYPE_SITE_DATA & 532 (content::BrowsingDataRemover::DATA_TYPE_COOKIES |
535 ~ChromeBrowsingDataRemoverDelegate::DATA_TYPE_DURABLE_PERMISSION & 533 content::BrowsingDataRemover::DATA_TYPE_CHANNEL_IDS |
536 ~ChromeBrowsingDataRemoverDelegate::DATA_TYPE_SITE_USAGE_DATA & 534 content::BrowsingDataRemover::DATA_TYPE_DOM_STORAGE) &
537 ~ChromeBrowsingDataRemoverDelegate::DATA_TYPE_PLUGIN_DATA & 535 ~content::BrowsingDataRemover::DATA_TYPE_EMBEDDER_DOM_STORAGE;
538 ~ChromeBrowsingDataRemoverDelegate::DATA_TYPE_EXTERNAL_PROTOCOL_DATA;
539 536
540 SetPrefsAndVerifySettings( 537 SetPrefsAndVerifySettings(
541 content::BrowsingDataRemover::DATA_TYPE_COOKIES | 538 content::BrowsingDataRemover::DATA_TYPE_COOKIES |
542 ChromeBrowsingDataRemoverDelegate::DATA_TYPE_HISTORY | 539 ChromeBrowsingDataRemoverDelegate::DATA_TYPE_HISTORY |
543 content::BrowsingDataRemover::DATA_TYPE_DOWNLOADS, 540 content::BrowsingDataRemover::DATA_TYPE_DOWNLOADS,
544 UNPROTECTED_WEB, 541 UNPROTECTED_WEB,
545 site_data_no_plugins_durable_usage_external | 542 supported_site_data |
546 ChromeBrowsingDataRemoverDelegate::DATA_TYPE_HISTORY | 543 ChromeBrowsingDataRemoverDelegate::DATA_TYPE_HISTORY |
547 content::BrowsingDataRemover::DATA_TYPE_DOWNLOADS); 544 content::BrowsingDataRemover::DATA_TYPE_DOWNLOADS);
548 } 545 }
OLDNEW
« no previous file with comments | « chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698