Improved support for loading client certificates on smart cards on macOS

net/ssl/client_cert_store_mac.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SSL_CLIENT_CERT_STORE_MAC_H_
 #define NET_SSL_CLIENT_CERT_STORE_MAC_H_
 
+#include <Security/Security.h>
+
 #include "base/callback.h"
 #include "base/macros.h"
 #include "net/base/net_export.h"
 #include "net/ssl/client_cert_store.h"
 #include "net/ssl/ssl_cert_request_info.h"
 
 namespace net {
 
 class NET_EXPORT ClientCertStoreMac : public ClientCertStore {
  public:
@@ skipping 20 matching lines @@
   // Testing hook specific to Mac, where the internal logic recognizes preferred
   // certificates for particular domains. If the preferred certificate is
   // present in the output list (i.e. it doesn't get filtered out), it should
   // always come first.
   bool SelectClientCertsGivenPreferredForTesting(
       const scoped_refptr<X509Certificate>& preferred_cert,
       const CertificateList& regular_certs,
       const SSLCertRequestInfo& request,
       CertificateList* selected_certs);
 
+
+  // Given an |identity|, adds it to either |regular_certs| or assigns
+  // |preferred_cert| if it it shte |preferred_identity.

[Ryan Sleevi, 2017/05/30 18:00:01]

typo: if it is the |preferred_identity|

[Ryan Sleevi, 2017/05/30 18:00:01]

Could you expand on what you're trying to document here? What's the distinction
between |preferred_identity| and |identity| here as the parameters? Some further
documentation seems warranted here in the header, although complete
documentation of the method in the header would be undesirable.

[agaynor, 2017/05/31 02:37:33]

Done.

+  void AddIdentity(
+      CertificateList& regular_certs,
+      scoped_refptr<X509Certificate>& preferred_cert,
+      SecIdentityRef preferred_identity,
+      SecIdentityRef identity);
+
+
   DISALLOW_COPY_AND_ASSIGN(ClientCertStoreMac);
 };
 
 }  // namespace net
 
 #endif  // NET_SSL_CLIENT_CERT_STORE_MAC_H_