Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: content/browser/shared_worker/worker_browsertest.cc

Issue 2910843002: [Cleanup] Move all browsertests to use ScopedFeatureList to modify features
Patch Set: Move SFL calls to constructor Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/shared_worker/worker_browsertest.cc
diff --git a/content/browser/shared_worker/worker_browsertest.cc b/content/browser/shared_worker/worker_browsertest.cc
index f991ff4e0043bf5a753f0e33dfe22983fcdd89ee..0497d703085c1ab96c5c8af7b1af639fce655a1d 100644
--- a/content/browser/shared_worker/worker_browsertest.cc
+++ b/content/browser/shared_worker/worker_browsertest.cc
@@ -10,6 +10,7 @@
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/sys_info.h"
+#include "base/test/scoped_feature_list.h"
#include "base/test/test_timeouts.h"
#include "build/build_config.h"
#include "content/public/browser/browser_thread.h"
@@ -111,16 +112,18 @@ class WorkerTest : public ContentBrowserTest {
class WorkerFetchTest : public testing::WithParamInterface<bool>,
public WorkerTest {
public:
- ~WorkerFetchTest() override {}
- void SetUpCommandLine(base::CommandLine* command_line) override {
+ WorkerFetchTest() {
if (GetParam()) {
- command_line->AppendSwitchASCII(switches::kEnableFeatures,
- features::kOffMainThreadFetch.name);
+ scoped_feature_list_.InitAndEnableFeature(features::kOffMainThreadFetch);
} else {
- command_line->AppendSwitchASCII(switches::kDisableFeatures,
- features::kOffMainThreadFetch.name);
+ scoped_feature_list_.InitAndDisableFeature(features::kOffMainThreadFetch);
}
}
+
+ ~WorkerFetchTest() override {}
+
+ private:
+ base::test::ScopedFeatureList scoped_feature_list_;
};
IN_PROC_BROWSER_TEST_F(WorkerTest, SingleWorker) {

Powered by Google App Engine
This is Rietveld 408576698