Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: content/browser/media/session/media_session_impl_visibility_browsertest.cc

Issue 2910843002: [Cleanup] Move all browsertests to use ScopedFeatureList to modify features
Patch Set: Move SFL calls to constructor Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_features.cc ('k') | content/browser/renderer_host/media/video_capture_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/session/media_session_impl_visibility_browsertest.cc
diff --git a/content/browser/media/session/media_session_impl_visibility_browsertest.cc b/content/browser/media/session/media_session_impl_visibility_browsertest.cc
index a5ad0b02355f8a76b1e74939e046ddf11099b063..2587abea0ec9282438e5b201f5c0fba9bcf2bb55 100644
--- a/content/browser/media/session/media_session_impl_visibility_browsertest.cc
+++ b/content/browser/media/session/media_session_impl_visibility_browsertest.cc
@@ -62,7 +62,12 @@ class MediaSessionImplVisibilityBrowserTest
: public ContentBrowserTest,
public ::testing::WithParamInterface<VisibilityTestData> {
public:
- MediaSessionImplVisibilityBrowserTest() = default;
+ MediaSessionImplVisibilityBrowserTest() {
+ VisibilityTestData params = GetVisibilityTestData();
+ EnableDisableResumingBackgroundVideos(params.background_resuming ==
+ BackgroundResuming::ENABLED);
+ }
+
~MediaSessionImplVisibilityBrowserTest() override = default;
void SetUpOnMainThread() override {
@@ -108,14 +113,6 @@ class MediaSessionImplVisibilityBrowserTest
command_line->AppendSwitch(switches::kEnableMediaSuspend);
else
command_line->AppendSwitch(switches::kDisableMediaSuspend);
-
- if (params.background_resuming == BackgroundResuming::ENABLED) {
- command_line->AppendSwitchASCII(switches::kEnableFeatures,
- media::kResumeBackgroundVideo.name);
- } else {
- command_line->AppendSwitchASCII(switches::kDisableFeatures,
- media::kResumeBackgroundVideo.name);
- }
}
const VisibilityTestData& GetVisibilityTestData() {
« no previous file with comments | « chrome/common/chrome_features.cc ('k') | content/browser/renderer_host/media/video_capture_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698