Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6923)

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 2910843002: [Cleanup] Move all browsertests to use ScopedFeatureList to modify features
Patch Set: Move SFL calls to constructor Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_browser_tests.cc
diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc
index 9b93a3375e2e00e84f7d728baabc212e94f9e5fa..1967e255d61fd74b282cff338e66bb4cf2b1cda5 100644
--- a/chrome/browser/ssl/ssl_browser_tests.cc
+++ b/chrome/browser/ssl/ssl_browser_tests.cc
@@ -2668,18 +2668,16 @@ class SSLUIWorkerFetchTest
std::pair<OffMainThreadFetchMode, SSLUIWorkerFetchTestType>>,
public SSLUITest {
public:
- ~SSLUIWorkerFetchTest() override {}
- void SetUpCommandLine(base::CommandLine* command_line) override {
- SSLUITest::SetUpCommandLine(command_line);
+ SSLUIWorkerFetchTest() {
if (GetParam().first == OffMainThreadFetchMode::kEnabled) {
- command_line->AppendSwitchASCII(switches::kEnableFeatures,
- features::kOffMainThreadFetch.name);
+ scoped_feature_list_.InitAndEnableFeature(features::kOffMainThreadFetch);
} else {
- command_line->AppendSwitchASCII(switches::kDisableFeatures,
- features::kOffMainThreadFetch.name);
+ scoped_feature_list_.InitAndDisableFeature(features::kOffMainThreadFetch);
}
}
+ ~SSLUIWorkerFetchTest() override {}
+
protected:
void GetTestWorkerPagePath(const net::EmbeddedTestServer& https_server,
std::string* test_worker_page_path) {
@@ -2694,6 +2692,9 @@ class SSLUIWorkerFetchTest
break;
}
}
+
+ private:
+ base::test::ScopedFeatureList scoped_feature_list_;
};
IN_PROC_BROWSER_TEST_P(SSLUIWorkerFetchTest,

Powered by Google App Engine
This is Rietveld 408576698