Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc

Issue 2910843002: [Cleanup] Move all browsertests to use ScopedFeatureList to modify features
Patch Set: Move SFL calls to constructor Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc
diff --git a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc b/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc
index 01535a44e2a68383550108db0c3e52cf79810967..a072128949a4496947d55fed2333e5230c271ff8 100644
--- a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc
+++ b/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc
@@ -7,6 +7,8 @@
#include "base/command_line.h"
#include "base/macros.h"
#include "base/test/histogram_tester.h"
+#include "base/test/scoped_feature_list.h"
+#include "chrome/common/chrome_features.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/common/content_switches.h"
@@ -16,13 +18,10 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
-const char kAdsMetricsFeature[] = "AdsMetrics";
-
class AdsPageLoadMetricsObserverBrowserTest : public InProcessBrowserTest {
public:
AdsPageLoadMetricsObserverBrowserTest() {
- base::CommandLine* cmd_line = base::CommandLine::ForCurrentProcess();
- cmd_line->AppendSwitchASCII(switches::kEnableFeatures, kAdsMetricsFeature);
+ scoped_feature_list_.InitAndEnableFeature(features::kAdsFeature);
}
~AdsPageLoadMetricsObserverBrowserTest() override {}
@@ -31,6 +30,7 @@ class AdsPageLoadMetricsObserverBrowserTest : public InProcessBrowserTest {
}
private:
+ base::test::ScopedFeatureList scoped_feature_list_;
DISALLOW_COPY_AND_ASSIGN(AdsPageLoadMetricsObserverBrowserTest);
};

Powered by Google App Engine
This is Rietveld 408576698