Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 2910843002: [Cleanup] Move all browsertests to use ScopedFeatureList to modify features
Patch Set: Ilya comments addressed Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_browsertest.cc
diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc
index 17cb6c4e11266b4739c69b3e1b8f7dd2d9dce3ab..2eea788ba6e5d1966fbd80d1750f86fa87296ae6 100644
--- a/content/browser/service_worker/service_worker_browsertest.cc
+++ b/content/browser/service_worker/service_worker_browsertest.cc
@@ -1336,10 +1336,13 @@ class ServiceWorkerVersionOffMainThreadFetchTest
: public ServiceWorkerVersionBrowserTest {
public:
~ServiceWorkerVersionOffMainThreadFetchTest() override {}
- void SetUpCommandLine(base::CommandLine* command_line) override {
- command_line->AppendSwitchASCII(switches::kEnableFeatures,
- features::kOffMainThreadFetch.name);
+ void SetUp() override {
+ scoped_feature_list_.InitAndEnableFeature(features::kOffMainThreadFetch);
+ ServiceWorkerVersionBrowserTest::SetUp();
}
+
+ private:
+ base::test::ScopedFeatureList scoped_feature_list_;
};
IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest, FetchWithSaveData) {
@@ -1550,10 +1553,10 @@ class ServiceWorkerNavigationPreloadTest : public ServiceWorkerBrowserTest {
ServiceWorkerBrowserTest::SetUpOnMainThread();
}
- void SetUpCommandLine(base::CommandLine* command_line) override {
- command_line->AppendSwitchASCII(
- switches::kEnableFeatures,
- features::kServiceWorkerNavigationPreload.name);
+ void SetUp() override {
+ scoped_feature_list_.InitAndEnableFeature(
+ features::kServiceWorkerNavigationPreload);
+ ServiceWorkerBrowserTest::SetUp();
}
protected:
@@ -1661,6 +1664,7 @@ class ServiceWorkerNavigationPreloadTest : public ServiceWorkerBrowserTest {
request_log_;
private:
+ base::test::ScopedFeatureList scoped_feature_list_;
class CustomResponse : public net::test_server::HttpResponse {
public:
CustomResponse(const std::string& response) : response_(response) {}

Powered by Google App Engine
This is Rietveld 408576698