Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 2910843002: [Cleanup] Move all browsertests to use ScopedFeatureList to modify features
Patch Set: Ilya comments addressed Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_browser_tests.cc
diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc
index dbdefe17cda376f58dcdc4810d72c0383430e4ab..355535a94675b649e8f181389c2994cb3349661e 100644
--- a/chrome/browser/ssl/ssl_browser_tests.cc
+++ b/chrome/browser/ssl/ssl_browser_tests.cc
@@ -2653,15 +2653,13 @@ class SSLUIWorkerFetchTest
public SSLUITest {
public:
~SSLUIWorkerFetchTest() override {}
- void SetUpCommandLine(base::CommandLine* command_line) override {
- SSLUITest::SetUpCommandLine(command_line);
+ void SetUp() override {
if (GetParam().first == OffMainThreadFetchMode::kEnabled) {
- command_line->AppendSwitchASCII(switches::kEnableFeatures,
- features::kOffMainThreadFetch.name);
+ scoped_feature_list_.InitAndEnableFeature(features::kOffMainThreadFetch);
} else {
- command_line->AppendSwitchASCII(switches::kDisableFeatures,
- features::kOffMainThreadFetch.name);
+ scoped_feature_list_.InitAndDisableFeature(features::kOffMainThreadFetch);
}
+ SSLUITest::SetUp();
}
protected:
@@ -2678,6 +2676,9 @@ class SSLUIWorkerFetchTest
break;
}
}
+
+ private:
+ base::test::ScopedFeatureList scoped_feature_list_;
};
IN_PROC_BROWSER_TEST_P(SSLUIWorkerFetchTest,

Powered by Google App Engine
This is Rietveld 408576698