Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6697)

Unified Diff: chrome/browser/net/predictor_browsertest.cc

Issue 2910843002: [Cleanup] Move all browsertests to use ScopedFeatureList to modify features
Patch Set: Ilya comments addressed Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/predictor_browsertest.cc
diff --git a/chrome/browser/net/predictor_browsertest.cc b/chrome/browser/net/predictor_browsertest.cc
index d1d7e8a392747c2e9552d62f7ff5608de490315f..93e49ce7c758a5e607cb7da4fbcdc906650f1907 100644
--- a/chrome/browser/net/predictor_browsertest.cc
+++ b/chrome/browser/net/predictor_browsertest.cc
@@ -22,15 +22,18 @@
#include "base/single_thread_task_runner.h"
#include "base/stl_util.h"
#include "base/synchronization/lock.h"
+#include "base/test/scoped_feature_list.h"
#include "base/threading/thread_task_runner_handle.h"
#include "build/build_config.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/browsing_data/browsing_data_helper.h"
#include "chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h"
#include "chrome/browser/net/predictor.h"
+#include "chrome/browser/net/predictor_tab_helper.h"
Ilya Sherman 2017/06/28 19:56:05 nit: Is this #include needed as part of this CL?
chaopeng 2017/06/30 19:32:36 Done.
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/common/chrome_features.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
@@ -517,11 +520,14 @@ class PredictorBrowserTest : public InProcessBrowserTest {
InProcessBrowserTest::SetUpInProcessBrowserTestFixture();
}
+ void SetUp() override {
+ scoped_feature_list_.InitAndEnableFeature(features::kPreconnectMore);
+ InProcessBrowserTest::SetUp();
+ }
+
void SetUpCommandLine(base::CommandLine* command_line) override {
command_line->AppendSwitch(
switches::kEnableExperimentalWebPlatformFeatures);
- command_line->AppendSwitchASCII(switches::kEnableFeatures,
- "PreconnectMore");
}
void SetUpOnMainThread() override {
@@ -798,6 +804,7 @@ class PredictorBrowserTest : public InProcessBrowserTest {
std::unique_ptr<net::EmbeddedTestServer> cross_site_test_server_;
std::unique_ptr<CrossSitePredictorObserver> observer_;
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
+ base::test::ScopedFeatureList scoped_feature_list_;
};
IN_PROC_BROWSER_TEST_F(PredictorBrowserTest, SingleLookupTest) {

Powered by Google App Engine
This is Rietveld 408576698