Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4209)

Unified Diff: chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc

Issue 2910843002: [Cleanup] Move all browsertests to use ScopedFeatureList to modify features
Patch Set: Ilya comments addressed Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc
diff --git a/chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc b/chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc
index f5cfe23c44afc5f300e8f025e0cd9b2c0d7ed990..b4fc0fbf5aeede11c79b3d8465d2b20118024d1a 100644
--- a/chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc
+++ b/chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc
@@ -8,6 +8,7 @@
#include "base/command_line.h"
#include "base/memory/ref_counted.h"
+#include "base/test/scoped_feature_list.h"
#include "chrome/browser/chromeos/extensions/input_method_event_router.h"
#include "chrome/common/chrome_features.h"
#include "chrome/common/pref_names.h"
@@ -76,14 +77,20 @@ class TestListener : public content::NotificationObserver {
};
class ExtensionInputMethodApiTest : public ExtensionApiTest {
+ public:
+ void SetUp() override {
+ scoped_feature_list_.InitAndEnableFeature(features::kOptInImeMenu);
+ ExtensionApiTest::SetUp();
+ }
Ilya Sherman 2017/06/28 19:56:04 nit: Please leave a blank line here.
chaopeng 2017/06/30 19:32:36 Done.
void SetUpCommandLine(base::CommandLine* command_line) override {
ExtensionApiTest::SetUpCommandLine(command_line);
command_line->AppendSwitchASCII(
extensions::switches::kWhitelistedExtensionID,
"ilanclmaeigfpnmdlgelmhkpkegdioip");
- command_line->AppendSwitchASCII(switches::kEnableFeatures,
- features::kOptInImeMenu.name);
}
+
+ private:
+ base::test::ScopedFeatureList scoped_feature_list_;
};
} // namespace
« no previous file with comments | « no previous file | chrome/browser/media/encrypted_media_browsertest.cc » ('j') | chrome/browser/metrics/ukm_browsertest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698