chrome/test/BUILD.gn - Issue 2910843002: [Cleanup] Move all browsertests to use ScopedFeatureList to modify features

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/BUILD.gn

Issue 2910843002: [Cleanup] Move all browsertests to use ScopedFeatureList to modify features

Patch Set: rebase update Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/BUILD.gn

diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn

index e7fa1829783397880b53afd0d2428a03d4f85c2a..667a7b4d6fd75f44e21f3bc14e7f4beb65add9e3 100644

--- a/chrome/test/BUILD.gn

+++ b/chrome/test/BUILD.gn

@@ -1112,6 +1112,8 @@ test("browser_tests") {

":repack_pseudo_locales",

":test_support",

"//base",

+ "//chrome/browser:browser",

Ilya Sherman 2017/06/12 21:50:29 Hmm, why did you add this dependency? It's alread

chaopeng 2017/06/28 19:21:24 Done.

+ "//components/safe_browsing_db:v4_feature_list",

Ilya Sherman 2017/06/12 21:50:29 Would this be appropriate to move down into the de

chaopeng 2017/06/28 19:21:24 Android does not need this. Moved to desktop-only.

"//components/spellcheck:build_features",

"//components/sync:test_support_model",

"//extensions/features",