chrome/browser/notifications/notification_interactive_uitest_support.h - Issue 2910843002: [Cleanup] Move all browsertests to use ScopedFeatureList to modify features

Side by Side Diff: chrome/browser/notifications/notification_interactive_uitest_support.h

Issue 2910843002: [Cleanup] Move all browsertests to use ScopedFeatureList to modify features

Patch Set: Ilya comments addressed Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/browser/net/predictor_browsertest.cc ('K') | « chrome/browser/net/predictor_tab_helper.cc ('k') | chrome/browser/notifications/notification_interactive_uitest_support.cc » ('j') | chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_INTERACTIVE_UITEST_SUPPORT_H_	5 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_INTERACTIVE_UITEST_SUPPORT_H_

6 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_INTERACTIVE_UITEST_SUPPORT_H_	6 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_INTERACTIVE_UITEST_SUPPORT_H_

7	7

8 #include "base/command_line.h"	8 #include "base/command_line.h"

9 #include "base/test/scoped_feature_list.h"	9 #include "base/test/scoped_feature_list.h"

10 #include "chrome/browser/permissions/permission_request_manager.h"	10 #include "chrome/browser/permissions/permission_request_manager.h"

(...skipping 12 matching lines...) Expand all Loading...
23 std::unique_ptr<Impl> impl_;	23 std::unique_ptr<Impl> impl_;

24	24

25 DISALLOW_COPY_AND_ASSIGN(MessageCenterChangeObserver);	25 DISALLOW_COPY_AND_ASSIGN(MessageCenterChangeObserver);

26 };	26 };

27	27

28 class NotificationsTest : public InProcessBrowserTest {	28 class NotificationsTest : public InProcessBrowserTest {

29 public:	29 public:

30 NotificationsTest() {}	30 NotificationsTest() {}

31	31

32 protected:	32 protected:

33 // InProcessBrowserTest overrides.	33 void SetUp() override;
Ilya Sherman 2017/06/28 19:56:05 nit: Please preserve this line. nit: Please preserve this line. chaopeng 2017/06/30 19:32:36 Done. Show quoted text On 2017/06/28 19:56:05, Ilya Sherman wrote: > nit: Please preserve this line. Done.
34 void SetUpDefaultCommandLine(base::CommandLine* command_line) override;

35	34

36 int GetNotificationCount();	35 int GetNotificationCount();

37 int GetNotificationPopupCount();	36 int GetNotificationPopupCount();

38	37

39 void CloseBrowserWindow(Browser* browser);	38 void CloseBrowserWindow(Browser* browser);

40 void CrashTab(Browser* browser, int index);	39 void CrashTab(Browser* browser, int index);

41	40

42 void DenyOrigin(const GURL& origin);	41 void DenyOrigin(const GURL& origin);

43 void AllowOrigin(const GURL& origin);	42 void AllowOrigin(const GURL& origin);

44 void AllowAllOrigins();	43 void AllowAllOrigins();

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
76	75

77 private:	76 private:

78 std::string RequestAndRespondToPermission(	77 std::string RequestAndRespondToPermission(

79 Browser* browser,	78 Browser* browser,

80 PermissionRequestManager::AutoResponseType bubble_response);	79 PermissionRequestManager::AutoResponseType bubble_response);

81	80

82 base::test::ScopedFeatureList feature_list_;	81 base::test::ScopedFeatureList feature_list_;

83 };	82 };

84	83

85 #endif // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_INTERACTIVE_UITEST_SUPPORT_ H_	84 #endif // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_INTERACTIVE_UITEST_SUPPORT_ H_

OLD	NEW