Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1745)

Unified Diff: content/renderer/render_frame_impl_browsertest.cc

Issue 2910783002: Adds Lo-Fi fallback support for new Data Reduction Proxy protocol. (Closed)
Patch Set: Added integration test the excercises page-polices fallback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl_browsertest.cc
diff --git a/content/renderer/render_frame_impl_browsertest.cc b/content/renderer/render_frame_impl_browsertest.cc
index 56e3d95058bb9faf2d7a44a4c4fad7e574ad4014..deff2df13da164ca7b7bfce7b59e74d61eb668f9 100644
--- a/content/renderer/render_frame_impl_browsertest.cc
+++ b/content/renderer/render_frame_impl_browsertest.cc
@@ -504,17 +504,17 @@ TEST_F(RenderFrameImplTest, ShouldUseClientLoFiForRequest) {
{CLIENT_LOFI_ON, false, WebURLRequest::kServerLoFiOn, false},
{PREVIEWS_UNSPECIFIED, false, WebURLRequest::kClientLoFiOn, true},
{CLIENT_LOFI_ON, false, WebURLRequest::kClientLoFiOn, true},
+ {CLIENT_LOFI_ON | SERVER_LITE_PAGE_ON, true,
+ WebURLRequest::kPreviewsUnspecified, true},
+ {CLIENT_LOFI_ON | SERVER_LITE_PAGE_ON, false,
+ WebURLRequest::kPreviewsUnspecified, true},
// If Client Lo-Fi isn't enabled for the frame, then it shouldn't be used
// for any requests.
{SERVER_LOFI_ON, true, WebURLRequest::kPreviewsUnspecified, false},
- // SERVER_LITE_PAGE_ON, PREVIEWS_NO_TRANSFORM, and PREVIEWS_OFF should
- // take precedence over Client Lo-Fi.
- {CLIENT_LOFI_ON | SERVER_LITE_PAGE_ON, false,
- WebURLRequest::kPreviewsUnspecified, false},
- {CLIENT_LOFI_ON | SERVER_LITE_PAGE_ON, true,
- WebURLRequest::kPreviewsUnspecified, false},
+ // PREVIEWS_NO_TRANSFORM and PREVIEWS_OFF should take precedence
+ // over Client Lo-Fi.
{CLIENT_LOFI_ON | PREVIEWS_NO_TRANSFORM, false,
WebURLRequest::kPreviewsUnspecified, false},
{CLIENT_LOFI_ON | PREVIEWS_OFF, false,

Powered by Google App Engine
This is Rietveld 408576698