Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 291073002: Move IsScaleFactorSupported, FindClosestScaleFactorUnsafe to ui/base/resource_bundle.cc (Closed)

Created:
6 years, 7 months ago by oshima
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Move IsScaleFactorSupported, FindClosestScaleFactorUnsafe to ui/base/resource_bundle.cc where they're used. BUG=372212 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271874

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -33 lines) Patch
M ui/base/layout.h View 1 1 chunk +0 lines, -8 lines 0 comments Download
M ui/base/layout.cc View 1 1 chunk +0 lines, -24 lines 0 comments Download
M ui/base/resource/resource_bundle.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 3 chunks +28 lines, -0 lines 0 comments Download
M ui/base/resource/resource_bundle_auralinux.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
oshima
6 years, 7 months ago (2014-05-20 18:24:37 UTC) #1
sky
LGTM
6 years, 7 months ago (2014-05-20 19:49:22 UTC) #2
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 7 months ago (2014-05-20 20:12:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/291073002/60001
6 years, 7 months ago (2014-05-20 20:12:36 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 22:54:37 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 22:58:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/68798)
6 years, 7 months ago (2014-05-20 22:58:54 UTC) #7
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 7 months ago (2014-05-20 23:00:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/291073002/80001
6 years, 7 months ago (2014-05-20 23:01:35 UTC) #9
oshima
The CQ bit was unchecked by oshima@chromium.org
6 years, 7 months ago (2014-05-21 07:24:16 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-21 07:27:06 UTC) #11
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 7 months ago (2014-05-21 08:42:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/291073002/80001
6 years, 7 months ago (2014-05-21 08:42:49 UTC) #13
oshima
6 years, 7 months ago (2014-05-21 09:27:43 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 manually as r271874 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698