Update some of the fixes to use ChangeBuilder

Update some of the fixes to use ChangeBuilder

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/f6c6c012118a48237eb7aa130d7f07e4fdc23440

[Brian Wilkerson, 2017-05-26 16:08:18]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-05-26 16:30:04]

LGTM

https://codereview.chromium.org/2910683002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right):

https://codereview.chromium.org/2910683002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/fix_internal.dart:501: await
changeBuilder.addFileEdit(file, fileStamp,
Could we add addDartFileEdit and type it with DartFileEditBuilder as the
callback parameter?

https://codereview.chromium.org/2910683002/diff/1/pkg/analyzer_plugin/lib/src...
File
pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
(right):

https://codereview.chromium.org/2910683002/diff/1/pkg/analyzer_plugin/lib/src...
pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart:1017:
if (!type.isVoid) {
Use Future<Null> instead of Future<void> for now?

[Brian Wilkerson, 2017-05-30 13:15:13]

PTAL

https://codereview.chromium.org/2910683002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right):

https://codereview.chromium.org/2910683002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/fix_internal.dart:501: await
changeBuilder.addFileEdit(file, fileStamp,
Casts removed after the change in the other CL.

https://codereview.chromium.org/2910683002/diff/1/pkg/analyzer_plugin/lib/src...
File
pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
(right):

https://codereview.chromium.org/2910683002/diff/1/pkg/analyzer_plugin/lib/src...
pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart:1017:
if (!type.isVoid) {
If this is important, I can fix it in a follow-up CL.

[scheglov, 2017-05-30 13:59:02]

LGTM

[Brian Wilkerson, 2017-05-30 15:01:55]

Description was changed from

==========
Update some of the fixes to use ChangeBuilder
==========

to

==========
Update some of the fixes to use ChangeBuilder

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f6c6c012118a48237eb7aa130d7f07e4fdc23440
==========

[Brian Wilkerson, 2017-05-30 15:01:56]

Committed patchset #2 (id:20001) manually as
f6c6c012118a48237eb7aa130d7f07e4fdc23440 (presubmit successful).