Issue 291063002: Fix misuses of DISALLOW_IMPLICIT_CONSTRUCTORS()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 291063002: Fix misuses of DISALLOW_IMPLICIT_CONSTRUCTORS() (Closed)

Created:
6 years, 7 months ago by mdempsky

Modified:
6 years, 7 months ago

Reviewers:
jln (very slow on Chromium)

CC:
chromium-reviews, darin-cc_chromium.org, jam, agl, jln+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix misuses of DISALLOW_IMPLICIT_CONSTRUCTORS() DISALLOW_IMPLICIT_CONSTRUCTORS() should be used when we don't want any implicit functions; but in the cases this CL touches, we just want the default constructor to be private, not disallowed. BUG=375000 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271592

Patch Set 1 #

Patch Set 2 : Sort declarations according to Google style guide #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -10 lines)			Patch
M	content/common/sandbox_linux/sandbox_linux.h	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	sandbox/linux/seccomp-bpf/trap.h	View	1	3 chunks	+9 lines, -7 lines	0 comments	Download
M	sandbox/linux/suid/client/setuid_sandbox_client.h	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdempsky@chromium.org/291063002/20001

6 years, 7 months ago (2014-05-20 00:42:19 UTC) #4

Message was sent while issue was closed.

Change committed as 271592

Expand Messages | Collapse Messages