Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2910583002: improve fasta interpolation recovery (Closed)

Created:
3 years, 6 months ago by danrubel
Modified:
3 years, 6 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

improve fasta interpolation recovery * improve fasta interpolation recovery by adding closing brace for unterminated string * update analyzer scanner test because fasta does not support does not support \r line endings R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/89283293392b970fc1574f4f2eff65b5b4304ece

Patch Set 1 #

Patch Set 2 : remove unnecessary label #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -31 lines) Patch
M pkg/analyzer/lib/src/dart/scanner/scanner.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 1 chunk +2 lines, -2 lines 2 comments Download
M pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart View 2 chunks +8 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart View 2 chunks +15 lines, -1 line 4 comments Download
M pkg/front_end/lib/src/fasta/scanner/recover.dart View 1 3 chunks +3 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/scanner/errors.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/scanner_fasta_test.dart View 4 chunks +31 lines, -8 lines 0 comments Download
M pkg/front_end/test/scanner_replacement_test.dart View 3 chunks +14 lines, -1 line 0 comments Download
M pkg/front_end/test/scanner_test.dart View 2 chunks +17 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
danrubel
3 years, 6 months ago (2017-05-26 02:02:12 UTC) #2
scheglov
lgtm
3 years, 6 months ago (2017-05-26 04:02:00 UTC) #3
danrubel
Committed patchset #2 (id:20001) manually as 89283293392b970fc1574f4f2eff65b5b4304ece (presubmit successful).
3 years, 6 months ago (2017-05-26 12:43:57 UTC) #5
ahe
lgtm https://codereview.chromium.org/2910583002/diff/20001/pkg/analyzer/test/generated/scanner_test.dart File pkg/analyzer/test/generated/scanner_test.dart (right): https://codereview.chromium.org/2910583002/diff/20001/pkg/analyzer/test/generated/scanner_test.dart#newcode82 pkg/analyzer/test/generated/scanner_test.dart:82: String source = "/*\r\n *\r\n */"; Perhaps Fasta ...
3 years, 6 months ago (2017-05-31 13:15:49 UTC) #6
danrubel
3 years, 6 months ago (2017-06-01 19:02:46 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/2910583002/diff/20001/pkg/analyzer/test/gener...
File pkg/analyzer/test/generated/scanner_test.dart (right):

https://codereview.chromium.org/2910583002/diff/20001/pkg/analyzer/test/gener...
pkg/analyzer/test/generated/scanner_test.dart:82: String source = "/*\r\n *\r\n
*/";
On 2017/05/31 13:15:48, ahe wrote:
> Perhaps Fasta should support \r line endings?

I don't think we need to do so given that most (all?) OS EOL is denoted by LF or
CR-LF. I'd rather not add more code to the scanner unless we need to support
this situation.

https://codereview.chromium.org/2910583002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart (right):

https://codereview.chromium.org/2910583002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart:264: * or an
unterminated string.
On 2017/05/31 13:15:48, ahe wrote:
> I think this is only called when it finds an unterminated string
interpolation.

Right. Fixed in https://codereview.chromium.org/2914213003/

https://codereview.chromium.org/2910583002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart:271: groupingStack
= groupingStack.tail;
On 2017/05/31 13:15:48, ahe wrote:
> What happens in this case:
> 
> "${([{
> 

Hmmm... good point. Fixed in https://codereview.chromium.org/2914213003/

Powered by Google App Engine
This is Rietveld 408576698