Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Unified Diff: chrome/browser/chromeos/net/network_portal_detector_impl.cc

Issue 2910503002: Revert "cros: Do not schedule attempt when behind captive portal with response 200 is detected" (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/net/network_portal_detector_impl.cc
diff --git a/chrome/browser/chromeos/net/network_portal_detector_impl.cc b/chrome/browser/chromeos/net/network_portal_detector_impl.cc
index 4b82822b6703c8625f232ac7f5f9b84f217cc7ed..2cec9cd3c45b968fde06a7735948442577539c8c 100644
--- a/chrome/browser/chromeos/net/network_portal_detector_impl.cc
+++ b/chrome/browser/chromeos/net/network_portal_detector_impl.cc
@@ -553,15 +553,8 @@ void NetworkPortalDetectorImpl::OnAttemptCompleted(
}
// Observers (via OnDetectionCompleted) may already schedule new attempt.
- if (!is_idle())
- return;
-
- // If behind a captive portal and the response code was 200 (OK), do not
- // schedule a new attempt.
- if (state.status == CAPTIVE_PORTAL_STATUS_PORTAL && response_code == 200)
- return;
-
- ScheduleAttempt(results.retry_after_delta);
+ if (is_idle())
+ ScheduleAttempt(results.retry_after_delta);
}
void NetworkPortalDetectorImpl::Observe(
« no previous file with comments | « no previous file | chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698