Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1429)

Unified Diff: net/url_request/url_request.h

Issue 2910473005: Deprecate NonThreadSafe in net/ in favor of SequenceChecker/ThreadChecker. (Closed)
Patch Set: rebase on r476634 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/test_url_fetcher_factory.cc ('k') | net/url_request/url_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request.h
diff --git a/net/url_request/url_request.h b/net/url_request/url_request.h
index 95a26676dcaeb6b7513d8fe502ff3376351bfbb2..41410703af7ee903e588d502d1284dcb7680e667 100644
--- a/net/url_request/url_request.h
+++ b/net/url_request/url_request.h
@@ -17,7 +17,7 @@
#include "base/optional.h"
#include "base/strings/string16.h"
#include "base/supports_user_data.h"
-#include "base/threading/non_thread_safe.h"
+#include "base/threading/thread_checker.h"
#include "base/time/time.h"
#include "net/base/auth.h"
#include "net/base/completion_callback.h"
@@ -69,8 +69,7 @@ class X509Certificate;
//
// NOTE: All usage of all instances of this class should be on the same thread.
//
-class NET_EXPORT URLRequest : NON_EXPORTED_BASE(public base::NonThreadSafe),
- public base::SupportsUserData {
+class NET_EXPORT URLRequest : public base::SupportsUserData {
public:
// Callback function implemented by protocol handlers to create new jobs.
// The factory may return NULL to indicate an error, which will cause other
@@ -862,6 +861,8 @@ class NET_EXPORT URLRequest : NON_EXPORTED_BASE(public base::NonThreadSafe),
const NetworkTrafficAnnotationTag traffic_annotation_;
+ THREAD_CHECKER(thread_checker_);
+
DISALLOW_COPY_AND_ASSIGN(URLRequest);
};
« no previous file with comments | « net/url_request/test_url_fetcher_factory.cc ('k') | net/url_request/url_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698