Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: net/dns/dns_config_service_posix.cc

Issue 2910473005: Deprecate NonThreadSafe in net/ in favor of SequenceChecker/ThreadChecker. (Closed)
Patch Set: rebase on r476634 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/dns/dns_config_service.cc ('k') | net/dns/dns_config_service_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/dns/dns_config_service_posix.cc
diff --git a/net/dns/dns_config_service_posix.cc b/net/dns/dns_config_service_posix.cc
index c9c9d9231af0c8ad6fbd23de4189d1461fb0218f..db701568c529dc97780c730a6bd03dd89efd6c3c 100644
--- a/net/dns/dns_config_service_posix.cc
+++ b/net/dns/dns_config_service_posix.cc
@@ -441,7 +441,7 @@ void DnsConfigServicePosix::OnHostsChanged(bool succeeded) {
void DnsConfigServicePosix::SetDnsConfigForTesting(
const DnsConfig* dns_config) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
dns_config_for_testing_ = dns_config;
// Reset ConfigReader to bind new DnsConfig for testing.
config_reader_->Cancel();
@@ -450,7 +450,7 @@ void DnsConfigServicePosix::SetDnsConfigForTesting(
void DnsConfigServicePosix::SetHostsFilePathForTesting(
const base::FilePath::CharType* file_path) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
file_path_hosts_ = file_path;
// Reset HostsReader to bind new hosts file path.
hosts_reader_->Cancel();
@@ -574,13 +574,13 @@ ConfigParsePosixResult ConvertResStateToDnsConfig(const struct __res_state& res,
bool DnsConfigServicePosix::SeenChangeSince(
const base::Time& since_time) const {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
return seen_config_change_;
}
void DnsConfigServicePosix::OnNetworkChanged(
NetworkChangeNotifier::ConnectionType type) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
DCHECK(watcher_);
watcher_->OnNetworkChanged(type);
}
« no previous file with comments | « net/dns/dns_config_service.cc ('k') | net/dns/dns_config_service_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698