Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: net/base/network_delegate.h

Issue 2910473005: Deprecate NonThreadSafe in net/ in favor of SequenceChecker/ThreadChecker. (Closed)
Patch Set: Fix chromecast compile Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/network_delegate.h
diff --git a/net/base/network_delegate.h b/net/base/network_delegate.h
index eaa1e3061c643c8bf4db58d8c9c83cad511e5701..914905e42ca4f2a3138ee601aa23c6a0331e30ac 100644
--- a/net/base/network_delegate.h
+++ b/net/base/network_delegate.h
@@ -10,8 +10,8 @@
#include <string>
#include "base/callback.h"
+#include "base/sequence_checker.h"
#include "base/strings/string16.h"
-#include "base/threading/non_thread_safe.h"
#include "net/base/auth.h"
#include "net/base/completion_callback.h"
#include "net/base/net_export.h"
@@ -46,7 +46,7 @@ class HttpResponseHeaders;
class ProxyInfo;
class URLRequest;
-class NET_EXPORT NetworkDelegate : public base::NonThreadSafe {
+class NET_EXPORT NetworkDelegate {
public:
// AuthRequiredResponse indicates how a NetworkDelegate handles an
// OnAuthRequired call. It's placed in this file to prevent url_request.h
@@ -59,7 +59,7 @@ class NET_EXPORT NetworkDelegate : public base::NonThreadSafe {
};
typedef base::Callback<void(AuthRequiredResponse)> AuthCallback;
- virtual ~NetworkDelegate() {}
+ virtual ~NetworkDelegate();
// Notification interface called by the network stack. Note that these
// functions mostly forward to the private virtuals. They also add some sanity
@@ -123,6 +123,9 @@ class NET_EXPORT NetworkDelegate : public base::NonThreadSafe {
bool CanUseReportingClient(const url::Origin& origin,
const GURL& endpoint) const;
+ protected:
+ SEQUENCE_CHECKER(sequence_checker_);
+
private:
// This is the interface for subclasses of NetworkDelegate to implement. These
// member functions will be called by the respective public notification

Powered by Google App Engine
This is Rietveld 408576698