net/http/http_cache.cc - Issue 2910473005: Deprecate NonThreadSafe in net/ in favor of SequenceChecker/ThreadChecker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_cache.cc

Issue 2910473005: Deprecate NonThreadSafe in net/ in favor of SequenceChecker/ThreadChecker. (Closed)

Patch Set: another compile nit Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_cache.cc

diff --git a/net/http/http_cache.cc b/net/http/http_cache.cc

index 519f192396b2ba8e070e8de497863720d74f52b3..bdb6cc5dd78ca7810b0a7a10ac4f43228c0cc779 100644

--- a/net/http/http_cache.cc

+++ b/net/http/http_cache.cc

@@ -336,6 +336,7 @@ HttpCache::HttpCache(std::unique_ptr<HttpTransactionFactory> network_layer,

}

HttpCache::~HttpCache() {

+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);

// Transactions should see an invalid cache after this point; otherwise they

// could see an inconsistent object (half destroyed).

weak_factory_.InvalidateWeakPtrs();