Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: chrome/browser/custom_handlers/protocol_handler_registry.cc

Issue 2910473005: Deprecate NonThreadSafe in net/ in favor of SequenceChecker/ThreadChecker. (Closed)
Patch Set: rebase on r476634 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chromecast/browser/cast_network_delegate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/custom_handlers/protocol_handler_registry.h" 5 #include "chrome/browser/custom_handlers/protocol_handler_registry.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 #include <utility> 10 #include <utility>
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 // JobInterceptorFactory ------------------------------------------------------- 162 // JobInterceptorFactory -------------------------------------------------------
163 163
164 // Instances of JobInterceptorFactory are produced for ownership by the IO 164 // Instances of JobInterceptorFactory are produced for ownership by the IO
165 // thread where it handler URL requests. We should never hold 165 // thread where it handler URL requests. We should never hold
166 // any pointers on this class, only produce them in response to 166 // any pointers on this class, only produce them in response to
167 // requests via |ProtocolHandlerRegistry::CreateJobInterceptorFactory|. 167 // requests via |ProtocolHandlerRegistry::CreateJobInterceptorFactory|.
168 ProtocolHandlerRegistry::JobInterceptorFactory::JobInterceptorFactory( 168 ProtocolHandlerRegistry::JobInterceptorFactory::JobInterceptorFactory(
169 IOThreadDelegate* io_thread_delegate) 169 IOThreadDelegate* io_thread_delegate)
170 : io_thread_delegate_(io_thread_delegate) { 170 : io_thread_delegate_(io_thread_delegate) {
171 DCHECK(io_thread_delegate_.get()); 171 DCHECK(io_thread_delegate_.get());
172 DetachFromThread(); 172 DETACH_FROM_THREAD(thread_checker_);
173 } 173 }
174 174
175 ProtocolHandlerRegistry::JobInterceptorFactory::~JobInterceptorFactory() { 175 ProtocolHandlerRegistry::JobInterceptorFactory::~JobInterceptorFactory() {
176 } 176 }
177 177
178 void ProtocolHandlerRegistry::JobInterceptorFactory::Chain( 178 void ProtocolHandlerRegistry::JobInterceptorFactory::Chain(
179 std::unique_ptr<net::URLRequestJobFactory> job_factory) { 179 std::unique_ptr<net::URLRequestJobFactory> job_factory) {
180 job_factory_ = std::move(job_factory); 180 job_factory_ = std::move(job_factory);
181 } 181 }
182 182
(...skipping 719 matching lines...) Expand 10 before | Expand all | Expand 10 after
902 902
903 std::unique_ptr<ProtocolHandlerRegistry::JobInterceptorFactory> 903 std::unique_ptr<ProtocolHandlerRegistry::JobInterceptorFactory>
904 ProtocolHandlerRegistry::CreateJobInterceptorFactory() { 904 ProtocolHandlerRegistry::CreateJobInterceptorFactory() {
905 DCHECK_CURRENTLY_ON(BrowserThread::UI); 905 DCHECK_CURRENTLY_ON(BrowserThread::UI);
906 // this is always created on the UI thread (in profile_io's 906 // this is always created on the UI thread (in profile_io's
907 // InitializeOnUIThread. Any method calls must be done 907 // InitializeOnUIThread. Any method calls must be done
908 // on the IO thread (this is checked). 908 // on the IO thread (this is checked).
909 return std::unique_ptr<JobInterceptorFactory>( 909 return std::unique_ptr<JobInterceptorFactory>(
910 new JobInterceptorFactory(io_thread_delegate_.get())); 910 new JobInterceptorFactory(io_thread_delegate_.get()));
911 } 911 }
OLDNEW
« no previous file with comments | « no previous file | chromecast/browser/cast_network_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698