Fix vm tests: introduce a hybrid file system so that the vm tests can find the

Fix vm tests: introduce a hybrid file system so that the vm tests can find the
sdk files.

The reason the tests broke is that they use a memory-file-system which only
contains the test file and a mock .packages file.

BUG= https://github.com/dart-lang/sdk/issues/29723
R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/edd835c5bb3e964e97db4211786d98c0f0dc4779

[Siggi Cherem (dart-lang), 2017-05-25 18:47:54]

sigmund@google.com changed reviewers:
+ aam@google.com, paulberry@google.com

[Siggi Cherem (dart-lang), 2017-05-25 18:47:55]

https://codereview.chromium.org/2910473003/diff/1/utils/application_snapshot.gni
File utils/application_snapshot.gni (right):

https://codereview.chromium.org/2910473003/diff/1/utils/application_snapshot....
utils/application_snapshot.gni:28: extra_inputs = [main_dart]
Not sure if this is the proper way to fix it, but I noticed that changing
kernel-service.dart was not enough to trigger a rebuild of the snapshot, this
fixes that.

[Paul Berry, 2017-05-25 19:19:25]

lgtm as a way to get the bot green again, but for the long term, I wonder: would
it be better to just include the missing file(s) in the memory file system
created by the kernel service?

[Siggi Cherem (dart-lang), 2017-05-25 19:22:54]

On 2017/05/25 19:19:25, Paul Berry wrote:
> lgtm as a way to get the bot green again, but for the long term, I wonder:
would
> it be better to just include the missing file(s) in the memory file system
> created by the kernel service?

Good question - I even started out that way, but realized that later we'll need
more. 

Right now is the .json file specifyign the sdk, but once we need the .dill for
the sdk we need to read it from the FS directly. Alex mentioned that some unit
tests that are disabled right now might be in that situation.

[Siggi Cherem (dart-lang), 2017-05-25 19:25:21]

Description was changed from

==========
Fix vm tests: introduce a hybrid file system so that the vm tests can find the
sdk files.

The reason the tests broke is that they use a memory-file-system which only
contains the test file and a mock .packages file.

BUG= https://github.com/dart-lang/sdk/issues/29723
==========

to

==========
Fix vm tests: introduce a hybrid file system so that the vm tests can find the
sdk files.

The reason the tests broke is that they use a memory-file-system which only
contains the test file and a mock .packages file.

BUG= https://github.com/dart-lang/sdk/issues/29723
R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/edd835c5bb3e964e97db4211786d98c0f0dc4779
==========

[Siggi Cherem (dart-lang), 2017-05-25 19:25:22]

Committed patchset #1 (id:1) manually as
edd835c5bb3e964e97db4211786d98c0f0dc4779 (presubmit successful).

[aam, 2017-05-25 19:41:42]

lgtm too

On 2017/05/25 19:22:54, Siggi Cherem (dart-lang) wrote:
> On 2017/05/25 19:19:25, Paul Berry wrote:
> > lgtm as a way to get the bot green again, but for the long term, I wonder:
> would
> > it be better to just include the missing file(s) in the memory file system
> > created by the kernel service?

Yeah, I agree, it seems it will be cleaner if runtime/vm/unit_test.cc is held
responsible for putting all artifacts into MemoryFileSystem.

> Good question - I even started out that way, but realized that later we'll
need more. 
> Right now is the .json file specifyign the sdk, but once we need the .dill for
> the sdk we need to read it from the FS directly. 

Potentially unit_test.cc could copy those .dills into memory too, unless it is
prohibitively slow.

> Alex mentioned that some unit tests that are disabled right now might be in
that situation.

Can't think of any existing unit tests that were disabled because of that, but
perhaps for future Flutter tests we will need to pass platform.dill together
with the script.dill

[aam, 2017-05-25 19:45:32]

Thank you Siggi for putting the fix together!