Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: net/http/http_network_transaction.cc

Issue 2910463004: Revert "Revert CLs landed in HttpStreamFactoryImpl to track down a crasher" (Closed)
Patch Set: rebased Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/bidirectional_stream.cc ('k') | net/http/http_network_transaction_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_transaction.cc
diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc
index 32aa872a96e32c90fce7abc17386e88ef57c45c1..1ac9bb2d2d26bb040cb764c58a2116e02b3c1d8e 100644
--- a/net/http/http_network_transaction.cc
+++ b/net/http/http_network_transaction.cc
@@ -840,17 +840,17 @@ int HttpNetworkTransaction::DoCreateStream() {
if (!enable_ip_based_pooling_)
DCHECK(!enable_alternative_services_);
if (ForWebSocketHandshake()) {
- stream_request_.reset(
+ stream_request_ =
session_->http_stream_factory_for_websocket()
->RequestWebSocketHandshakeStream(
*request_, priority_, server_ssl_config_, proxy_ssl_config_,
this, websocket_handshake_stream_base_create_helper_,
enable_ip_based_pooling_, enable_alternative_services_,
- net_log_));
+ net_log_);
} else {
- stream_request_.reset(session_->http_stream_factory()->RequestStream(
+ stream_request_ = session_->http_stream_factory()->RequestStream(
*request_, priority_, server_ssl_config_, proxy_ssl_config_, this,
- enable_ip_based_pooling_, enable_alternative_services_, net_log_));
+ enable_ip_based_pooling_, enable_alternative_services_, net_log_);
}
DCHECK(stream_request_.get());
return ERR_IO_PENDING;
« no previous file with comments | « net/http/bidirectional_stream.cc ('k') | net/http/http_network_transaction_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698