Issue 291043002: identity.getAccounts should return one array instead of multiple AccountInfos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 291043002: identity.getAccounts should return one array instead of multiple AccountInfos (Closed)

Created:
6 years, 7 months ago by Michael Courage

Modified:
6 years, 7 months ago

Reviewers:
fgorski

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

identity.getAccounts should return one array instead of multiple AccountInfos BUG=374973 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271542

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -4 lines)			Patch
	M	chrome/browser/extensions/api/identity/identity_api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/extensions/api/identity/identity_apitest.cc	View		1 chunk	+12 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

Michael Courage

All bugs can be resolved with an additional layer of indirection.

6 years, 7 months ago (2014-05-19 22:34:49 UTC) #1

fgorski

lgtm, but I think the bug number in description might be incorrect.

6 years, 7 months ago (2014-05-19 23:08:12 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/courage@chromium.org/291043002/1

6 years, 7 months ago (2014-05-19 23:21:25 UTC) #4

Message was sent while issue was closed.

Change committed as 271542