 Chromium Code Reviews
 Chromium Code Reviews Issue 2910383002:
  mash: Add catalog/manifest etc. for telemetry tests binary for mash.  (Closed)
    
  
    Issue 2910383002:
  mash: Add catalog/manifest etc. for telemetry tests binary for mash.  (Closed) 
  | OLD | NEW | 
|---|---|
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be | 
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. | 
| 4 | 4 | 
| 5 #include "chrome/app/chrome_main_delegate.h" | 5 #include "chrome/app/chrome_main_delegate.h" | 
| 6 | 6 | 
| 7 #include <stddef.h> | 7 #include <stddef.h> | 
| 8 #include <string> | 8 #include <string> | 
| 9 | 9 | 
| 10 #include "base/base_paths.h" | 10 #include "base/base_paths.h" | 
| (...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 103 #if defined(OS_CHROMEOS) | 103 #if defined(OS_CHROMEOS) | 
| 104 #include "base/sys_info.h" | 104 #include "base/sys_info.h" | 
| 105 #include "chrome/browser/chromeos/boot_times_recorder.h" | 105 #include "chrome/browser/chromeos/boot_times_recorder.h" | 
| 106 #include "chromeos/chromeos_paths.h" | 106 #include "chromeos/chromeos_paths.h" | 
| 107 #include "chromeos/chromeos_switches.h" | 107 #include "chromeos/chromeos_switches.h" | 
| 108 #include "chromeos/hugepage_text/hugepage_text.h" | 108 #include "chromeos/hugepage_text/hugepage_text.h" | 
| 109 #endif | 109 #endif | 
| 110 | 110 | 
| 111 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES) | 111 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES) | 
| 112 #include "chrome/app/mash/chrome_mash_catalog.h" | 112 #include "chrome/app/mash/chrome_mash_catalog.h" | 
| 113 #include "chrome/app/mash/chrome_test_catalog.h" | |
| 113 #include "chrome/app/mash/embedded_services.h" | 114 #include "chrome/app/mash/embedded_services.h" | 
| 114 #include "mash/common/config.h" // nogncheck | 115 #include "mash/common/config.h" // nogncheck | 
| 115 #include "mash/quick_launch/public/interfaces/constants.mojom.h" // nogncheck | 116 #include "mash/quick_launch/public/interfaces/constants.mojom.h" // nogncheck | 
| 116 #include "services/ui/public/interfaces/constants.mojom.h" // nogncheck | 117 #include "services/ui/public/interfaces/constants.mojom.h" // nogncheck | 
| 117 | 118 | 
| 118 #if defined(OS_CHROMEOS) | 119 #if defined(OS_CHROMEOS) | 
| 119 #include "chrome/app/mash/chrome_mus_catalog.h" | 120 #include "chrome/app/mash/chrome_mus_catalog.h" | 
| 120 #endif | 121 #endif | 
| 121 | 122 | 
| 122 #endif // BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES) | 123 #endif // BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES) | 
| (...skipping 1004 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1127 return service_manager::ProcessType::kDefault; | 1128 return service_manager::ProcessType::kDefault; | 
| 1128 } | 1129 } | 
| 1129 | 1130 | 
| 1130 std::unique_ptr<base::Value> ChromeMainDelegate::CreateServiceCatalog() { | 1131 std::unique_ptr<base::Value> ChromeMainDelegate::CreateServiceCatalog() { | 
| 1131 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES) | 1132 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES) | 
| 1132 const auto& command_line = *base::CommandLine::ForCurrentProcess(); | 1133 const auto& command_line = *base::CommandLine::ForCurrentProcess(); | 
| 1133 #if defined(OS_CHROMEOS) | 1134 #if defined(OS_CHROMEOS) | 
| 1134 if (command_line.HasSwitch(switches::kMus)) | 1135 if (command_line.HasSwitch(switches::kMus)) | 
| 1135 return CreateChromeMusCatalog(); | 1136 return CreateChromeMusCatalog(); | 
| 1136 #endif // defined(OS_CHROMEOS) | 1137 #endif // defined(OS_CHROMEOS) | 
| 1137 if (command_line.HasSwitch(switches::kMash)) | 1138 if (command_line.HasSwitch(switches::kMash)) { | 
| 1139 if (command_line.HasSwitch("use-test-config")) | |
| 
sky
2017/06/01 20:45:24
Should we consider a completely separate build tar
 
sadrul
2017/06/01 20:49:43
Yep. That's where I was initially going. To do tha
 | |
| 1140 return CreateChromeTestCatalog(); | |
| 1138 return CreateChromeMashCatalog(); | 1141 return CreateChromeMashCatalog(); | 
| 1142 } | |
| 1139 #endif // BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES) | 1143 #endif // BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES) | 
| 1140 return nullptr; | 1144 return nullptr; | 
| 1141 } | 1145 } | 
| 1142 | 1146 | 
| 1143 void ChromeMainDelegate::AdjustServiceProcessCommandLine( | 1147 void ChromeMainDelegate::AdjustServiceProcessCommandLine( | 
| 1144 const service_manager::Identity& identity, | 1148 const service_manager::Identity& identity, | 
| 1145 base::CommandLine* command_line) { | 1149 base::CommandLine* command_line) { | 
| 1146 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES) | 1150 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES) | 
| 1147 // Add kMusConfig so that launched processes know what config they are | 1151 // Add kMusConfig so that launched processes know what config they are | 
| 1148 // running in. | 1152 // running in. | 
| (...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1211 | 1215 | 
| 1212 std::unique_ptr<service_manager::Service> | 1216 std::unique_ptr<service_manager::Service> | 
| 1213 ChromeMainDelegate::CreateEmbeddedService(const std::string& service_name) { | 1217 ChromeMainDelegate::CreateEmbeddedService(const std::string& service_name) { | 
| 1214 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES) | 1218 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES) | 
| 1215 auto mash_service = CreateEmbeddedMashService(service_name); | 1219 auto mash_service = CreateEmbeddedMashService(service_name); | 
| 1216 if (mash_service) | 1220 if (mash_service) | 
| 1217 return mash_service; | 1221 return mash_service; | 
| 1218 #endif // BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES) | 1222 #endif // BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES) | 
| 1219 return nullptr; | 1223 return nullptr; | 
| 1220 } | 1224 } | 
| OLD | NEW |