 Chromium Code Reviews
 Chromium Code Reviews Issue 2910383002:
  mash: Add catalog/manifest etc. for telemetry tests binary for mash.  (Closed)
    
  
    Issue 2910383002:
  mash: Add catalog/manifest etc. for telemetry tests binary for mash.  (Closed) 
  | OLD | NEW | 
|---|---|
| 1 # Copyright 2016 The Chromium Authors. All rights reserved. | 1 # Copyright 2016 The Chromium Authors. All rights reserved. | 
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be | 
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. | 
| 4 | 4 | 
| 5 import("//build/config/nacl/config.gni") | 5 import("//build/config/nacl/config.gni") | 
| 6 import("//chrome/common/features.gni") | 6 import("//chrome/common/features.gni") | 
| 7 import("//services/catalog/public/tools/catalog.gni") | 7 import("//services/catalog/public/tools/catalog.gni") | 
| 8 import("//services/service_manager/public/service_manifest.gni") | 8 import("//services/service_manager/public/service_manifest.gni") | 
| 9 | 9 | 
| 10 assert(enable_package_mash_services) | 10 assert(enable_package_mash_services) | 
| (...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 93 if (enable_nacl && is_chromeos) { | 93 if (enable_nacl && is_chromeos) { | 
| 94 embedded_services += [ "//components/nacl/loader:nacl_loader_manifest" ] | 94 embedded_services += [ "//components/nacl/loader:nacl_loader_manifest" ] | 
| 95 } | 95 } | 
| 96 } | 96 } | 
| 97 | 97 | 
| 98 catalog_cpp_source("chrome_mash_catalog") { | 98 catalog_cpp_source("chrome_mash_catalog") { | 
| 99 catalog = ":catalog" | 99 catalog = ":catalog" | 
| 100 generated_function_name = "CreateChromeMashCatalog" | 100 generated_function_name = "CreateChromeMashCatalog" | 
| 101 } | 101 } | 
| 102 | 102 | 
| 103 catalog("catalog_telemetry") { | |
| 
Ken Rockot(use gerrit already)
2017/05/31 11:34:23
You should be able to consolidate most of the dupl
 
sadrul
2017/05/31 13:19:24
Done.
 | |
| 104 embedded_services = [ | |
| 105 "//ash/autoclick/mus:manifest", | |
| 106 "//ash/touch_hud/mus:manifest", | |
| 107 "//mash/catalog_viewer:manifest", | |
| 108 "//mash/quick_launch:manifest", | |
| 109 "//mash/session:manifest", | |
| 110 "//mash/task_viewer:manifest", | |
| 111 "//services/ui:manifest", | |
| 112 "//services/ui/ime/test_ime_driver:manifest", | |
| 113 ] | |
| 114 catalog_deps = [ "//chrome/app:catalog_for_telemetry_tests_mash" ] | |
| 115 standalone_services = [ | |
| 116 "//mash/example/views_examples:manifest", | |
| 117 "//mash/simple_wm:manifest", | |
| 118 ] | |
| 119 | |
| 120 if (is_chromeos) { | |
| 121 embedded_services += [ "//ash/mus:manifest" ] | |
| 122 } | |
| 123 | |
| 124 if (is_linux && !is_android) { | |
| 125 embedded_services += [ "//components/font_service:manifest" ] | |
| 126 } | |
| 127 | |
| 128 if (enable_nacl && is_chromeos) { | |
| 129 embedded_services += [ "//components/nacl/loader:nacl_loader_manifest" ] | |
| 130 } | |
| 131 } | |
| 132 | |
| 133 catalog_cpp_source("chrome_telemetry_catalog") { | |
| 134 catalog = ":catalog_telemetry" | |
| 135 generated_function_name = "CreateChromeTelemetryCatalog" | |
| 136 } | |
| 137 | |
| 103 if (is_chromeos) { | 138 if (is_chromeos) { | 
| 104 catalog("catalog_mus") { | 139 catalog("catalog_mus") { | 
| 105 catalog_deps = [ "//chrome/app:catalog" ] | 140 catalog_deps = [ "//chrome/app:catalog" ] | 
| 106 embedded_services = [ | 141 embedded_services = [ | 
| 107 "//services/ui:manifest", | 142 "//services/ui:manifest", | 
| 108 | 143 | 
| 109 # TODO(sky): verify if we need this. | 144 # TODO(sky): verify if we need this. | 
| 110 "//services/ui/ime/test_ime_driver:manifest", | 145 "//services/ui/ime/test_ime_driver:manifest", | 
| 111 ] | 146 ] | 
| 112 | 147 | 
| 113 if (enable_nacl) { | 148 if (enable_nacl) { | 
| 114 embedded_services += [ "//components/nacl/loader:nacl_loader_manifest" ] | 149 embedded_services += [ "//components/nacl/loader:nacl_loader_manifest" ] | 
| 115 } | 150 } | 
| 116 } | 151 } | 
| 117 | 152 | 
| 118 catalog_cpp_source("chrome_mus_catalog") { | 153 catalog_cpp_source("chrome_mus_catalog") { | 
| 119 catalog = ":catalog_mus" | 154 catalog = ":catalog_mus" | 
| 120 generated_function_name = "CreateChromeMusCatalog" | 155 generated_function_name = "CreateChromeMusCatalog" | 
| 121 } | 156 } | 
| 122 } | 157 } | 
| OLD | NEW |