Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: tools/skpdiff/SkImageDiffer.h

Issue 29103005: update skpdiff visualization (image magnification with alpha mask) (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/skpdiff/SkImageDiffer.h
diff --git a/tools/skpdiff/SkImageDiffer.h b/tools/skpdiff/SkImageDiffer.h
index 6c570cbb8e41bc3d8437937047f55396cd262258..b46ba65b2b948e2e5c1504ac6b9f111ad6f2ab02 100644
--- a/tools/skpdiff/SkImageDiffer.h
+++ b/tools/skpdiff/SkImageDiffer.h
@@ -37,6 +37,11 @@ public:
virtual bool requiresOpenCL() { return false; }
/**
+ *
+ */
+ virtual void enablePOIAlphaMask() { fPOIAlphaMask = true; }
epoger 2013/10/21 15:02:53 Related to my comments above about fPOIAlphaMask:
djsollen 2013/11/06 16:02:30 Done.
+
+ /**
* Wraps a call to queueDiff by loading the given filenames into SkBitmaps
* @param baseline The file path of the baseline image
* @param test The file path of the test image
@@ -87,10 +92,15 @@ public:
*/
virtual SkIPoint* getPointsOfInterest(int id) = 0;
+ /*
+ *
+ */
+ virtual SkBitmap* getPointsOfInterestAlphaMask(int id) { return NULL; }
protected:
bool fIsGood;
+ bool fPOIAlphaMask;
};

Powered by Google App Engine
This is Rietveld 408576698