Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2910233002: Do not fallback to FocusedOrMainFrame() in FocusedLocalFrameInWidget() (Closed)
Patch Set: Addressing dcheng@'s comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 578 matching lines...) Expand 10 before | Expand all | Expand 10 after
589 void UpdatePageOverlays(); 589 void UpdatePageOverlays();
590 590
591 float DeviceScaleFactor() const; 591 float DeviceScaleFactor() const;
592 592
593 void SetRootGraphicsLayer(GraphicsLayer*) override; 593 void SetRootGraphicsLayer(GraphicsLayer*) override;
594 void SetRootLayer(WebLayer*) override; 594 void SetRootLayer(WebLayer*) override;
595 void AttachCompositorAnimationTimeline(CompositorAnimationTimeline*); 595 void AttachCompositorAnimationTimeline(CompositorAnimationTimeline*);
596 void DetachCompositorAnimationTimeline(CompositorAnimationTimeline*); 596 void DetachCompositorAnimationTimeline(CompositorAnimationTimeline*);
597 597
598 LocalFrame* FocusedLocalFrameInWidget() const; 598 LocalFrame* FocusedLocalFrameInWidget() const;
599 LocalFrame* FocusedLocalFrameAvailableForIme() const;
600 599
601 CompositorMutatorImpl& Mutator(); 600 CompositorMutatorImpl& Mutator();
602 601
603 WebViewClient* client_; // Can be 0 (e.g. unittests, shared workers, etc.) 602 WebViewClient* client_; // Can be 0 (e.g. unittests, shared workers, etc.)
604 WebSpellCheckClient* spell_check_client_; 603 WebSpellCheckClient* spell_check_client_;
605 604
606 // ChromeClient needs blink:: qualifier so it doesn't clash with ChromeClient 605 // ChromeClient needs blink:: qualifier so it doesn't clash with ChromeClient
607 // method. TODO(sashab): Rename getter to GetChromeClient to fix this. 606 // method. TODO(sashab): Rename getter to GetChromeClient to fix this.
608 Persistent<blink::ChromeClient> chrome_client_; 607 Persistent<blink::ChromeClient> chrome_client_;
609 ContextMenuClientImpl context_menu_client_impl_; 608 ContextMenuClientImpl context_menu_client_impl_;
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
654 653
655 float compositor_device_scale_factor_override_; 654 float compositor_device_scale_factor_override_;
656 TransformationMatrix device_emulation_transform_; 655 TransformationMatrix device_emulation_transform_;
657 656
658 // Webkit expects keyPress events to be suppressed if the associated keyDown 657 // Webkit expects keyPress events to be suppressed if the associated keyDown
659 // event was handled. Safari implements this behavior by peeking out the 658 // event was handled. Safari implements this behavior by peeking out the
660 // associated WM_CHAR event if the keydown was handled. We emulate 659 // associated WM_CHAR event if the keydown was handled. We emulate
661 // this behavior by setting this flag if the keyDown was handled. 660 // this behavior by setting this flag if the keyDown was handled.
662 bool suppress_next_keypress_event_; 661 bool suppress_next_keypress_event_;
663 662
664 // TODO(ekaramad): Can we remove this and make sure IME events are not called
665 // when there is no page focus?
666 // Represents whether or not this object should process incoming IME events.
667 bool ime_accept_events_;
668
669 // The popup associated with an input/select element. 663 // The popup associated with an input/select element.
670 RefPtr<WebPagePopupImpl> page_popup_; 664 RefPtr<WebPagePopupImpl> page_popup_;
671 665
672 // This stores the last hidden page popup. If a GestureTap attempts to open 666 // This stores the last hidden page popup. If a GestureTap attempts to open
673 // the popup that is closed by its previous GestureTapDown, the popup remains 667 // the popup that is closed by its previous GestureTapDown, the popup remains
674 // closed. 668 // closed.
675 RefPtr<WebPagePopupImpl> last_hidden_page_popup_; 669 RefPtr<WebPagePopupImpl> last_hidden_page_popup_;
676 670
677 Persistent<DevToolsEmulator> dev_tools_emulator_; 671 Persistent<DevToolsEmulator> dev_tools_emulator_;
678 std::unique_ptr<PageOverlay> page_color_overlay_; 672 std::unique_ptr<PageOverlay> page_color_overlay_;
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
745 Persistent<ResizeViewportAnchor> resize_viewport_anchor_; 739 Persistent<ResizeViewportAnchor> resize_viewport_anchor_;
746 }; 740 };
747 741
748 // We have no ways to check if the specified WebView is an instance of 742 // We have no ways to check if the specified WebView is an instance of
749 // WebViewImpl because WebViewImpl is the only implementation of WebView. 743 // WebViewImpl because WebViewImpl is the only implementation of WebView.
750 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true); 744 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
751 745
752 } // namespace blink 746 } // namespace blink
753 747
754 #endif 748 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698