Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2910233002: Do not fallback to FocusedOrMainFrame() in FocusedLocalFrameInWidget() (Closed)
Patch Set: Fixed a crashing test Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 643 matching lines...) Expand 10 before | Expand all | Expand 10 after
654 654
655 float compositor_device_scale_factor_override_; 655 float compositor_device_scale_factor_override_;
656 TransformationMatrix device_emulation_transform_; 656 TransformationMatrix device_emulation_transform_;
657 657
658 // Webkit expects keyPress events to be suppressed if the associated keyDown 658 // Webkit expects keyPress events to be suppressed if the associated keyDown
659 // event was handled. Safari implements this behavior by peeking out the 659 // event was handled. Safari implements this behavior by peeking out the
660 // associated WM_CHAR event if the keydown was handled. We emulate 660 // associated WM_CHAR event if the keydown was handled. We emulate
661 // this behavior by setting this flag if the keyDown was handled. 661 // this behavior by setting this flag if the keyDown was handled.
662 bool suppress_next_keypress_event_; 662 bool suppress_next_keypress_event_;
663 663
664 // TODO(ekaramad): Can we remove this and make sure IME events are not called
665 // when there is no page focus?
666 // Represents whether or not this object should process incoming IME events.
667 bool ime_accept_events_;
668
669 // The popup associated with an input/select element. 664 // The popup associated with an input/select element.
670 RefPtr<WebPagePopupImpl> page_popup_; 665 RefPtr<WebPagePopupImpl> page_popup_;
671 666
672 // This stores the last hidden page popup. If a GestureTap attempts to open 667 // This stores the last hidden page popup. If a GestureTap attempts to open
673 // the popup that is closed by its previous GestureTapDown, the popup remains 668 // the popup that is closed by its previous GestureTapDown, the popup remains
674 // closed. 669 // closed.
675 RefPtr<WebPagePopupImpl> last_hidden_page_popup_; 670 RefPtr<WebPagePopupImpl> last_hidden_page_popup_;
676 671
677 Persistent<DevToolsEmulator> dev_tools_emulator_; 672 Persistent<DevToolsEmulator> dev_tools_emulator_;
678 std::unique_ptr<PageOverlay> page_color_overlay_; 673 std::unique_ptr<PageOverlay> page_color_overlay_;
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
745 Persistent<ResizeViewportAnchor> resize_viewport_anchor_; 740 Persistent<ResizeViewportAnchor> resize_viewport_anchor_;
746 }; 741 };
747 742
748 // We have no ways to check if the specified WebView is an instance of 743 // We have no ways to check if the specified WebView is an instance of
749 // WebViewImpl because WebViewImpl is the only implementation of WebView. 744 // WebViewImpl because WebViewImpl is the only implementation of WebView.
750 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true); 745 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
751 746
752 } // namespace blink 747 } // namespace blink
753 748
754 #endif 749 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698