Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2910233002: Do not fallback to FocusedOrMainFrame() in FocusedLocalFrameInWidget() (Closed)
Patch Set: Rebased Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 564 matching lines...) Expand 10 before | Expand all | Expand 10 after
575 void UpdatePageOverlays(); 575 void UpdatePageOverlays();
576 576
577 float DeviceScaleFactor() const; 577 float DeviceScaleFactor() const;
578 578
579 void SetRootGraphicsLayer(GraphicsLayer*) override; 579 void SetRootGraphicsLayer(GraphicsLayer*) override;
580 void SetRootLayer(WebLayer*) override; 580 void SetRootLayer(WebLayer*) override;
581 void AttachCompositorAnimationTimeline(CompositorAnimationTimeline*); 581 void AttachCompositorAnimationTimeline(CompositorAnimationTimeline*);
582 void DetachCompositorAnimationTimeline(CompositorAnimationTimeline*); 582 void DetachCompositorAnimationTimeline(CompositorAnimationTimeline*);
583 583
584 LocalFrame* FocusedLocalFrameInWidget() const; 584 LocalFrame* FocusedLocalFrameInWidget() const;
585 LocalFrame* FocusedLocalFrameAvailableForIme() const;
586 585
587 CompositorMutatorImpl& Mutator(); 586 CompositorMutatorImpl& Mutator();
588 587
589 WebViewClient* client_; // Can be 0 (e.g. unittests, shared workers, etc.) 588 WebViewClient* client_; // Can be 0 (e.g. unittests, shared workers, etc.)
590 589
591 Persistent<ChromeClient> chrome_client_; 590 Persistent<ChromeClient> chrome_client_;
592 ContextMenuClient context_menu_client_; 591 ContextMenuClient context_menu_client_;
593 EditorClient editor_client_; 592 EditorClient editor_client_;
594 SpellCheckerClientImpl spell_checker_client_impl_; 593 SpellCheckerClientImpl spell_checker_client_impl_;
595 StorageClientImpl storage_client_impl_; 594 StorageClientImpl storage_client_impl_;
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
637 636
638 float compositor_device_scale_factor_override_; 637 float compositor_device_scale_factor_override_;
639 TransformationMatrix device_emulation_transform_; 638 TransformationMatrix device_emulation_transform_;
640 639
641 // Webkit expects keyPress events to be suppressed if the associated keyDown 640 // Webkit expects keyPress events to be suppressed if the associated keyDown
642 // event was handled. Safari implements this behavior by peeking out the 641 // event was handled. Safari implements this behavior by peeking out the
643 // associated WM_CHAR event if the keydown was handled. We emulate 642 // associated WM_CHAR event if the keydown was handled. We emulate
644 // this behavior by setting this flag if the keyDown was handled. 643 // this behavior by setting this flag if the keyDown was handled.
645 bool suppress_next_keypress_event_; 644 bool suppress_next_keypress_event_;
646 645
647 // TODO(ekaramad): Can we remove this and make sure IME events are not called
648 // when there is no page focus?
649 // Represents whether or not this object should process incoming IME events.
650 bool ime_accept_events_;
651
652 // The popup associated with an input/select element. 646 // The popup associated with an input/select element.
653 RefPtr<WebPagePopupImpl> page_popup_; 647 RefPtr<WebPagePopupImpl> page_popup_;
654 648
655 // This stores the last hidden page popup. If a GestureTap attempts to open 649 // This stores the last hidden page popup. If a GestureTap attempts to open
656 // the popup that is closed by its previous GestureTapDown, the popup remains 650 // the popup that is closed by its previous GestureTapDown, the popup remains
657 // closed. 651 // closed.
658 RefPtr<WebPagePopupImpl> last_hidden_page_popup_; 652 RefPtr<WebPagePopupImpl> last_hidden_page_popup_;
659 653
660 Persistent<DevToolsEmulator> dev_tools_emulator_; 654 Persistent<DevToolsEmulator> dev_tools_emulator_;
661 std::unique_ptr<PageOverlay> page_color_overlay_; 655 std::unique_ptr<PageOverlay> page_color_overlay_;
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
728 Persistent<ResizeViewportAnchor> resize_viewport_anchor_; 722 Persistent<ResizeViewportAnchor> resize_viewport_anchor_;
729 }; 723 };
730 724
731 // We have no ways to check if the specified WebView is an instance of 725 // We have no ways to check if the specified WebView is an instance of
732 // WebViewImpl because WebViewImpl is the only implementation of WebView. 726 // WebViewImpl because WebViewImpl is the only implementation of WebView.
733 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true); 727 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
734 728
735 } // namespace blink 729 } // namespace blink
736 730
737 #endif 731 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698