Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1358)

Side by Side Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.h

Issue 2910233002: Do not fallback to FocusedOrMainFrame() in FocusedLocalFrameInWidget() (Closed)
Patch Set: Rebased Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 // PageWidgetEventHandler functions 176 // PageWidgetEventHandler functions
177 void HandleMouseLeave(LocalFrame&, const WebMouseEvent&) override; 177 void HandleMouseLeave(LocalFrame&, const WebMouseEvent&) override;
178 void HandleMouseDown(LocalFrame&, const WebMouseEvent&) override; 178 void HandleMouseDown(LocalFrame&, const WebMouseEvent&) override;
179 void HandleMouseUp(LocalFrame&, const WebMouseEvent&) override; 179 void HandleMouseUp(LocalFrame&, const WebMouseEvent&) override;
180 WebInputEventResult HandleMouseWheel(LocalFrame&, 180 WebInputEventResult HandleMouseWheel(LocalFrame&,
181 const WebMouseWheelEvent&) override; 181 const WebMouseWheelEvent&) override;
182 WebInputEventResult HandleGestureEvent(const WebGestureEvent&) override; 182 WebInputEventResult HandleGestureEvent(const WebGestureEvent&) override;
183 WebInputEventResult HandleKeyEvent(const WebKeyboardEvent&) override; 183 WebInputEventResult HandleKeyEvent(const WebKeyboardEvent&) override;
184 WebInputEventResult HandleCharEvent(const WebKeyboardEvent&) override; 184 WebInputEventResult HandleCharEvent(const WebKeyboardEvent&) override;
185 185
186 // This method returns the focused frame belonging to this WebWidget, that
187 // is, a focused frame with the same local root as the one corresponding
188 // to this widget. It will return nullptr if no frame is focused or, the
189 // focused frame has a different local root.
190 LocalFrame* FocusedLocalFrameInWidget() const;
191
192 LocalFrame* FocusedLocalFrameAvailableForIme() const;
193
194 CompositorMutatorImpl& Mutator(); 186 CompositorMutatorImpl& Mutator();
195 187
196 WebWidgetClient* client_; 188 WebWidgetClient* client_;
197 189
198 // WebFrameWidget is associated with a subtree of the frame tree, 190 // WebFrameWidget is associated with a subtree of the frame tree,
199 // corresponding to a maximal connected tree of LocalFrames. This member 191 // corresponding to a maximal connected tree of LocalFrames. This member
200 // points to the root of that subtree. 192 // points to the root of that subtree.
201 Member<WebLocalFrameBase> local_root_; 193 Member<WebLocalFrameBase> local_root_;
202 194
203 WebSize size_; 195 WebSize size_;
(...skipping 14 matching lines...) Expand all
218 bool is_accelerated_compositing_active_; 210 bool is_accelerated_compositing_active_;
219 bool layer_tree_view_closed_; 211 bool layer_tree_view_closed_;
220 212
221 bool suppress_next_keypress_event_; 213 bool suppress_next_keypress_event_;
222 214
223 bool background_color_override_enabled_; 215 bool background_color_override_enabled_;
224 WebColor background_color_override_; 216 WebColor background_color_override_;
225 bool base_background_color_override_enabled_; 217 bool base_background_color_override_enabled_;
226 WebColor base_background_color_override_; 218 WebColor base_background_color_override_;
227 219
228 // TODO(ekaramad): Can we remove this and make sure IME events are not called
229 // when there is no page focus?
230 // Represents whether or not this object should process incoming IME events.
231 bool ime_accept_events_;
232
233 static const WebInputEvent* current_input_event_; 220 static const WebInputEvent* current_input_event_;
234 221
235 WebColor base_background_color_; 222 WebColor base_background_color_;
236 223
237 SelfKeepAlive<WebFrameWidgetImpl> self_keep_alive_; 224 SelfKeepAlive<WebFrameWidgetImpl> self_keep_alive_;
238 }; 225 };
239 226
240 DEFINE_TYPE_CASTS(WebFrameWidgetImpl, 227 DEFINE_TYPE_CASTS(WebFrameWidgetImpl,
241 WebFrameWidgetBase, 228 WebFrameWidgetBase,
242 widget, 229 widget,
243 widget->ForSubframe(), 230 widget->ForSubframe(),
244 widget.ForSubframe()); 231 widget.ForSubframe());
245 232
246 } // namespace blink 233 } // namespace blink
247 234
248 #endif 235 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp ('k') | third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698