Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: ui/login/account_picker/md_screen_account_picker.js

Issue 2910203003: Handling edge cases of new login screen (Closed)
Patch Set: Adjust animation duration and add small screen handling Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/login/account_picker/md_screen_account_picker.css ('k') | ui/login/account_picker/md_user_pod_row.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/login/account_picker/md_screen_account_picker.js
diff --git a/ui/login/account_picker/md_screen_account_picker.js b/ui/login/account_picker/md_screen_account_picker.js
index e7830ec8256c9f09c6eec0f18fc7324050413e98..88ca6736d29011c8e2b851dff02530fac037c0be 100644
--- a/ui/login/account_picker/md_screen_account_picker.js
+++ b/ui/login/account_picker/md_screen_account_picker.js
@@ -71,12 +71,6 @@ login.createScreen('AccountPickerScreen', 'account-picker', function() {
/** @override */
onWindowResize: function() {
$('pod-row').onWindowResize();
-
- // Reposition the error bubble, if it is showing. Since we are just
- // moving the bubble, the number of login attempts tried doesn't matter.
- var errorBubble = $('bubble');
- if (errorBubble && !errorBubble.hidden)
- this.showErrorBubble(0, undefined /* Reuses the existing message. */);
},
/**
@@ -362,9 +356,7 @@ login.createScreen('AccountPickerScreen', 'account-picker', function() {
* @param {string} message Text to be displayed or empty to hide the banner.
*/
showBannerMessage: function(message) {
- var banner = $('signin-banner');
- banner.textContent = message;
- banner.classList.toggle('message-set', !!message);
+ $('pod-row').showBannerMessage(message);
},
/**
« no previous file with comments | « ui/login/account_picker/md_screen_account_picker.css ('k') | ui/login/account_picker/md_user_pod_row.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698