Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issue 2910153004: Hash pin using existing hash algorithm (Closed)

Created:
3 years, 6 months ago by xiaoyinh(OOO Sep 11-29)
Modified:
3 years, 3 months ago
Reviewers:
xiyuan, jdufault
CC:
chromium-reviews, extensions-reviews_chromium.org, alemate+watch_chromium.org, sadrul, achuith+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, davemoore+watch_chromium.org, rkc
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pin is hashed differently than password in PinStorage. This CL updates LockScreenController to hash pin using its existing hash algorithm. BUG=721524

Patch Set 1 #

Total comments: 2

Patch Set 2 : hash pin with existing hash algorithm to ensure backwards compatibility #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -41 lines) Patch
M ash/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ash/login/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M ash/login/lock_screen_controller.h View 1 3 chunks +17 lines, -2 lines 2 comments Download
M ash/login/lock_screen_controller.cc View 1 2 chunks +35 lines, -7 lines 1 comment Download
M ash/shell.h View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/shell.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/quick_unlock/pin_storage.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/quick_unlock/pin_storage.cc View 1 4 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/quick_unlock/pin_storage_unittest.cc View 1 3 chunks +28 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/quick_unlock/quick_unlock_storage.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/quick_unlock/quick_unlock_storage.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/lock_screen_client.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M ui/login/account_picker/md_user_pod_row.js View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/login/account_picker/user_pod_row.js View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
xiaoyinh(OOO Sep 11-29)
Hi jdufault@, xiyuan@, could you take a look and let me know? Thank you!
3 years, 6 months ago (2017-05-30 22:26:00 UTC) #10
jdufault
https://codereview.chromium.org/2910153004/diff/1/chrome/browser/chromeos/login/quick_unlock/pin_storage.cc File chrome/browser/chromeos/login/quick_unlock/pin_storage.cc (right): https://codereview.chromium.org/2910153004/diff/1/chrome/browser/chromeos/login/quick_unlock/pin_storage.cc#newcode28 chrome/browser/chromeos/login/quick_unlock/pin_storage.cc:28: key.Transform(Key::KEY_TYPE_SALTED_SHA256_TOP_HALF, salt); It seems like this will break existing ...
3 years, 6 months ago (2017-05-31 00:00:45 UTC) #11
xiaoyinh(OOO Sep 11-29)
https://codereview.chromium.org/2910153004/diff/1/chrome/browser/chromeos/login/quick_unlock/pin_storage.cc File chrome/browser/chromeos/login/quick_unlock/pin_storage.cc (right): https://codereview.chromium.org/2910153004/diff/1/chrome/browser/chromeos/login/quick_unlock/pin_storage.cc#newcode28 chrome/browser/chromeos/login/quick_unlock/pin_storage.cc:28: key.Transform(Key::KEY_TYPE_SALTED_SHA256_TOP_HALF, salt); On 2017/05/31 00:00:45, jdufault wrote: > It ...
3 years, 6 months ago (2017-06-01 20:47:22 UTC) #19
jdufault
https://codereview.chromium.org/2910153004/diff/20001/ash/login/lock_screen_controller.cc File ash/login/lock_screen_controller.cc (right): https://codereview.chromium.org/2910153004/diff/20001/ash/login/lock_screen_controller.cc#newcode67 ash/login/lock_screen_controller.cc:67: // TODO: In some corner case, user could have ...
3 years, 6 months ago (2017-06-08 00:56:39 UTC) #20
xiyuan
lgtm https://codereview.chromium.org/2910153004/diff/20001/ash/login/lock_screen_controller.h File ash/login/lock_screen_controller.h (right): https://codereview.chromium.org/2910153004/diff/20001/ash/login/lock_screen_controller.h#newcode66 ash/login/lock_screen_controller.h:66: PrefService* active_user_pref_service_ = nullptr; On 2017/06/08 00:56:38, jdufault ...
3 years, 6 months ago (2017-06-08 15:24:05 UTC) #21
xiyuan
On 2017/06/08 15:24:05, xiyuan wrote: > lgtm > > https://codereview.chromium.org/2910153004/diff/20001/ash/login/lock_screen_controller.h > File ash/login/lock_screen_controller.h (right): > ...
3 years, 6 months ago (2017-06-08 15:24:34 UTC) #22
xiaoyinh(OOO Sep 11-29)
3 years, 3 months ago (2017-09-06 19:10:55 UTC) #23

Powered by Google App Engine
This is Rietveld 408576698