Remove views::Label::SetDisabledColor(). Replace with typography colors.

chrome/browser/ui/views/profiles/profile_chooser_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/profiles/profile_chooser_view.h"
 
 #include "base/macros.h"
 #include "base/metrics/user_metrics.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/app/vector_icons/vector_icons.h"
@@ skipping 243 matching lines @@
             : nullptr);
 
     SkColor text_color = GetNativeTheme()->GetSystemColor(
         is_selected ? ui::NativeTheme::kColorId_SelectedMenuItemForegroundColor
                     : ui::NativeTheme::kColorId_LabelEnabledColor);
     SetEnabledTextColors(text_color);
     if (title_)
       title_->SetEnabledColor(text_color);
 
     if (subtitle_) {
-      DCHECK(!subtitle_->enabled());
-      subtitle_->SetDisabledColor(GetNativeTheme()->GetSystemColor(
+      subtitle_->SetEnabledColor(GetNativeTheme()->GetSystemColor(
           is_selected
               ? ui::NativeTheme::kColorId_DisabledMenuItemForegroundColor
               : ui::NativeTheme::kColorId_LabelDisabledColor));

[Peter Kasting, 2017/06/01 04:55:58]

Is there a TODO here to use the typography provider to set the colors?  Seems
like this isn't really "disabled" any more than the other cases you're fixing.

[tapted, 2017/06/01 11:22:18]

Heh, yeah I'd considered this. But if the samples on the typography spec at
https://bugs.chromium.org/p/chromium/issues/attachment?aid=286827&inline=1 can
be trusted then it's likely that the email should be primary, and the text above
it should be the "hint". (In which case the TODO might belong closer to
`email_label`). So it may be more involved than just switching these to use
GetFont, but we won't know until this UI has a mock.

Left a note.

     }
   }
 
   views::Label* title_;
   views::Label* subtitle_;
 
   DISALLOW_COPY_AND_ASSIGN(BackgroundColorHoverButton);
 };
 
 // A view to host the GAIA webview overlapped with a back button.  This class
@@ skipping 885 matching lines @@
           new BackgroundColorHoverButton(this, button_text);
       manage_accounts_button_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
       manage_accounts_button_->SetMinSize(
           gfx::Size(kFixedMenuWidth, kButtonHeight));
       view->AddChildView(manage_accounts_button_);
     } else {
       views::Label* email_label = new views::Label(avatar_item.username);
       current_profile_card->set_subtitle(email_label);
       email_label->SetAutoColorReadabilityEnabled(false);
       email_label->SetElideBehavior(gfx::ELIDE_EMAIL);
-      email_label->SetEnabled(false);
       email_label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
       grid_layout->StartRow(1, 0);
       // Skip first column for the profile icon.
       grid_layout->SkipColumns(1);
       grid_layout->AddView(email_label, 1, 1, views::GridLayout::LEADING,
                            views::GridLayout::LEADING);
     }
 
     current_profile_card_->SetAccessibleName(
         l10n_util::GetStringFUTF16(
@@ skipping 440 matching lines @@
       IncognitoModePrefs::GetAvailability(browser_->profile()->GetPrefs()) !=
           IncognitoModePrefs::DISABLED;
   return incognito_available && !browser_->profile()->IsGuestSession();
 }
 
 void ProfileChooserView::PostActionPerformed(
     ProfileMetrics::ProfileDesktopMenu action_performed) {
   ProfileMetrics::LogProfileDesktopMenu(action_performed, gaia_service_type_);
   gaia_service_type_ = signin::GAIA_SERVICE_TYPE_NONE;
 }