Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2910033002: Fail tests that use ClickOnView() on an inactive window.

Created:
3 years, 6 months ago by tapted
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, mac-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fail tests that use ClickOnView() on an inactive window. Tests that do will flake too easily. On Mac, there seems to be no guarantee that the WindowServer will send the event to the window, or activate it. It isn't enough just to wait for NSWindowDidBecomeKeyNotification after invoking ClickOnView(). On Windows BUG=726132, 639130, 523255, 293445, 412086, 133361, 45892

Patch Set 1 #

Patch Set 2 : Fail more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/test/base/interactive_test_utils_cocoa.mm View 1 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/test/base/interactive_test_utils_views.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (9 generated)
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-05-30 00:54:14 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910033002/1
3 years, 6 months ago (2017-05-30 00:54:26 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-05-30 01:25:58 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/465243)
3 years, 6 months ago (2017-05-30 01:25:59 UTC) #4
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-05-30 02:41:02 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910033002/20001
3 years, 6 months ago (2017-05-30 02:41:17 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-05-30 03:04:56 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/437085)
3 years, 6 months ago (2017-05-30 03:04:56 UTC) #8
tapted
3 years, 6 months ago (2017-05-30 03:38:51 UTC) #9 
Description was changed from

==========
Fail tests that use ClickOnView() on an inactive window.

Tests that do will flake too easily. There seems to be no guarantee that
the WindowServer will send the event to the window, or activate it. It
isn't enough just to wait for NSWindowDidBecomeKeyNotification after
invoking ClickOnView().

BUG=726132
==========

to

==========
Fail tests that use ClickOnView() on an inactive window.

Tests that do will flake too easily. On Mac, there seems to be no guarantee that
the WindowServer will send the event to the window, or activate it. It
isn't enough just to wait for NSWindowDidBecomeKeyNotification after
invoking ClickOnView().

On Windows

BUG=726132, 639130, 523255, 293445, 412086, 133361, 45892
==========

Powered by Google App Engine
This is Rietveld 408576698