Move OverscrollController to RenderWidgetHostViewAura

content/browser/frame_host/navigation_entry_screenshot_manager.cc

Index: content/browser/frame_host/navigation_entry_screenshot_manager.cc
diff --git a/content/browser/frame_host/navigation_entry_screenshot_manager.cc b/content/browser/frame_host/navigation_entry_screenshot_manager.cc
index 08791f906020019ff974578a477dc6523d2acb21..77a257ad1291ac922a61c1b7cc02f0925dff4024 100644
--- a/content/browser/frame_host/navigation_entry_screenshot_manager.cc
+++ b/content/browser/frame_host/navigation_entry_screenshot_manager.cc
@@ -98,10 +98,11 @@ void NavigationEntryScreenshotManager::TakeScreenshot() {
 
   RenderViewHost* render_view_host =
       owner_->delegate()->GetRenderViewHost();
-  if (!static_cast<RenderViewHostImpl*>
+  // TODO(jdduke): Determine if necessary?
+  /*if (!static_cast<RenderViewHostImpl*>
       (render_view_host)->overscroll_controller()) {
     return;
-  }
+  }*/

[sadrul, 2014/05/22 16:18:27]

The screenshots are used only when overscroll is turned on at the moment. This
is to avoid having to take the screenshots if they are not going to be used.

[jdduke (slow), 2014/05/22 16:21:31]

Any ideas on another way to plumb through this data? I'd hate to do some ugly
casting if this can be used on platforms besides Aura (I believe we compile it
for all platforms?).

[sadrul, 2014/05/22 16:53:20]

We compile it on all platforms, yeah.

Maybe we could have a static bool OverscrollController::IsEnabled() that looks
at the cmd-line flag?

[jdduke (slow), 2014/05/22 19:29:38]

Hmm, I started down that road and found some runtime cases where it starts to
get messy.  I added a |CanOverscrollContent()| to the nav delegate that I think
gets us most of the way there (and the method is actually already implemented
generically in the WebContentsImpl).

   content::RenderWidgetHostView* view = render_view_host->GetView();
   if (!view)
     return;