Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1605)

Unified Diff: content/browser/web_contents/web_contents_view_aura.cc

Issue 291003002: Move OverscrollController to RenderWidgetHostViewAura (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DCHECK_GE Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_view_aura.h ('k') | ui/events/gestures/gesture_configuration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_view_aura.cc
diff --git a/content/browser/web_contents/web_contents_view_aura.cc b/content/browser/web_contents/web_contents_view_aura.cc
index 368060a425d5ad3812f0a13d761b07eb8b067a14..772d2afea3cf78f5ac661eedfca3c43a4cc0bddb 100644
--- a/content/browser/web_contents/web_contents_view_aura.cc
+++ b/content/browser/web_contents/web_contents_view_aura.cc
@@ -768,7 +768,7 @@ void WebContentsViewAura::EndDrag(blink::WebDragOperationsMask ops) {
}
void WebContentsViewAura::InstallOverscrollControllerDelegate(
- RenderWidgetHostImpl* host) {
+ RenderWidgetHostViewAura* view) {
const std::string value = CommandLine::ForCurrentProcess()->
GetSwitchValueASCII(switches::kOverscrollHistoryNavigation);
if (value == "0") {
@@ -779,10 +779,10 @@ void WebContentsViewAura::InstallOverscrollControllerDelegate(
navigation_overlay_.reset();
if (!gesture_nav_simple_)
gesture_nav_simple_.reset(new GestureNavSimple(web_contents_));
- host->overscroll_controller()->set_delegate(gesture_nav_simple_.get());
+ view->overscroll_controller()->set_delegate(gesture_nav_simple_.get());
return;
}
- host->overscroll_controller()->set_delegate(this);
+ view->overscroll_controller()->set_delegate(this);
if (!navigation_overlay_)
navigation_overlay_.reset(new OverscrollNavigationOverlay(web_contents_));
}
@@ -1101,8 +1101,8 @@ RenderWidgetHostViewBase* WebContentsViewAura::CreateViewForWidget(
render_widget_host->GetView());
}
- RenderWidgetHostViewBase* view = new RenderWidgetHostViewAura(
- render_widget_host);
+ RenderWidgetHostViewAura* view =
+ new RenderWidgetHostViewAura(render_widget_host);
view->InitAsChild(NULL);
GetNativeView()->AddChild(view->GetNativeView());
@@ -1119,10 +1119,10 @@ RenderWidgetHostViewBase* WebContentsViewAura::CreateViewForWidget(
// We listen to drag drop events in the newly created view's window.
aura::client::SetDragDropDelegate(view->GetNativeView(), this);
- if (host_impl->overscroll_controller() &&
+ if (view->overscroll_controller() &&
(!web_contents_->GetDelegate() ||
web_contents_->GetDelegate()->CanOverscrollContent())) {
- InstallOverscrollControllerDelegate(host_impl);
+ InstallOverscrollControllerDelegate(view);
}
AttachTouchEditableToRenderView();
@@ -1148,12 +1148,12 @@ void WebContentsViewAura::RenderViewSwappedIn(RenderViewHost* host) {
}
void WebContentsViewAura::SetOverscrollControllerEnabled(bool enabled) {
- RenderViewHostImpl* host = static_cast<RenderViewHostImpl*>(
- web_contents_->GetRenderViewHost());
- if (host) {
- host->SetOverscrollControllerEnabled(enabled);
+ RenderWidgetHostViewAura* view =
+ ToRenderWidgetHostViewAura(web_contents_->GetRenderWidgetHostView());
+ if (view) {
+ view->SetOverscrollControllerEnabled(enabled);
if (enabled)
- InstallOverscrollControllerDelegate(host);
+ InstallOverscrollControllerDelegate(view);
}
if (!enabled)
« no previous file with comments | « content/browser/web_contents/web_contents_view_aura.h ('k') | ui/events/gestures/gesture_configuration.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698