third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp - Issue 2910023002: Ensure RemoteViewportIntersection rect persists across frame navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 2910023002: Ensure RemoteViewportIntersection rect persists across frame navigations (Closed)

Patch Set: ncarter comments addressed Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

index c30f0442862025bbce8c46bf6b49d547409832da..98063fcc63a0f92eb7eb372293a1b4440d15af37 100644

--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

@@ -766,8 +766,8 @@ void WebFrameWidgetImpl::SetRemoteViewportIntersection(

// Remote viewports are only applicable to local frames with remote ancestors.

DCHECK(local_root_->Parent() && local_root_->Parent()->IsWebRemoteFrame());

- if (local_root_->GetFrameView()) {

- local_root_->GetFrameView()->SetViewportIntersectionFromParent(

+ if (local_root_->GetFrame()) {

+ local_root_->GetFrame()->SetViewportIntersectionFromParent(

viewport_intersection);

}