Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2910023002: Ensure RemoteViewportIntersection rect persists across frame navigations (Closed)
Patch Set: ncarter comments addressed Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalFrame.h
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.h b/third_party/WebKit/Source/core/frame/LocalFrame.h
index d29aea93f4fc45ca49f5bbc9166070b8e65e7dbd..f49e7d0995ddd052064c685dfe1d0ebf892cfdf9 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.h
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.h
@@ -255,6 +255,12 @@ class CORE_EXPORT LocalFrame final : public Frame,
// focused element or passed node into explicit methods.
WebPluginContainerBase* GetWebPluginContainerBase(Node* = nullptr) const;
+ // Called on a view for a LocalFrame with a RemoteFrame parent. This makes
+ // viewport intersection available that accounts for remote ancestor frames
+ // and their respective scroll positions, clips, etc.
+ void SetViewportIntersectionFromParent(const IntRect&);
+ IntRect RemoteViewportIntersection() { return remote_viewport_intersection_; }
+
private:
friend class FrameNavigationDisabler;
@@ -305,6 +311,8 @@ class CORE_EXPORT LocalFrame final : public Frame,
InterfaceProvider* const interface_provider_;
InterfaceRegistry* const interface_registry_;
+
+ IntRect remote_viewport_intersection_;
dcheng 2017/05/30 19:54:11 It feels a little weird to have layout information
kenrb 2017/05/30 21:19:21 Similar idea, yes. I think frame-specific values t
};
inline FrameLoader& LocalFrame::Loader() const {

Powered by Google App Engine
This is Rietveld 408576698