Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: third_party/WebKit/Source/core/frame/LocalFrameView.cpp

Issue 2910023002: Ensure RemoteViewportIntersection rect persists across frame navigations (Closed)
Patch Set: dcheng comments addressed Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 5301 matching lines...) Expand 10 before | Expand all | Expand 10 after
5312 .c_str()); 5312 .c_str());
5313 return result; 5313 return result;
5314 } 5314 }
5315 5315
5316 String result(MainThreadScrollingReason::mainThreadScrollingReasonsAsText( 5316 String result(MainThreadScrollingReason::mainThreadScrollingReasonsAsText(
5317 main_thread_scrolling_reasons_) 5317 main_thread_scrolling_reasons_)
5318 .c_str()); 5318 .c_str());
5319 return result; 5319 return result;
5320 } 5320 }
5321 5321
5322 void LocalFrameView::SetViewportIntersectionFromParent(
5323 const IntRect& viewport_intersection) {
5324 if (remote_viewport_intersection_ != viewport_intersection) {
5325 remote_viewport_intersection_ = viewport_intersection;
5326 ScheduleAnimation();
5327 }
5328 }
5329
5330 IntRect LocalFrameView::RemoteViewportIntersection() { 5322 IntRect LocalFrameView::RemoteViewportIntersection() {
5331 IntRect intersection(remote_viewport_intersection_); 5323 IntRect intersection(GetFrame().RemoteViewportIntersection());
5332 intersection.Move(ScrollOffsetInt()); 5324 intersection.Move(ScrollOffsetInt());
5333 return intersection; 5325 return intersection;
5334 } 5326 }
5335 5327
5336 void LocalFrameView::MapQuadToAncestorFrameIncludingScrollOffset( 5328 void LocalFrameView::MapQuadToAncestorFrameIncludingScrollOffset(
5337 LayoutRect& rect, 5329 LayoutRect& rect,
5338 const LayoutObject* descendant, 5330 const LayoutObject* descendant,
5339 const LayoutView* ancestor, 5331 const LayoutView* ancestor,
5340 MapCoordinatesFlags mode) { 5332 MapCoordinatesFlags mode) {
5341 FloatQuad mapped_quad = descendant->LocalToAncestorQuad( 5333 FloatQuad mapped_quad = descendant->LocalToAncestorQuad(
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
5386 void LocalFrameView::SetAnimationHost( 5378 void LocalFrameView::SetAnimationHost(
5387 std::unique_ptr<CompositorAnimationHost> host) { 5379 std::unique_ptr<CompositorAnimationHost> host) {
5388 animation_host_ = std::move(host); 5380 animation_host_ = std::move(host);
5389 } 5381 }
5390 5382
5391 LayoutUnit LocalFrameView::CaretWidth() const { 5383 LayoutUnit LocalFrameView::CaretWidth() const {
5392 return LayoutUnit(GetChromeClient()->WindowToViewportScalar(1)); 5384 return LayoutUnit(GetChromeClient()->WindowToViewportScalar(1));
5393 } 5385 }
5394 5386
5395 } // namespace blink 5387 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698