Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 2910023002: Ensure RemoteViewportIntersection rect persists across frame navigations (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 // entirely, which comes first. 310 // entirely, which comes first.
311 virtual bool IsRenderWidgetHostViewGuest(); 311 virtual bool IsRenderWidgetHostViewGuest();
312 312
313 // Subclass identifier for RenderWidgetHostViewChildFrames. This is useful 313 // Subclass identifier for RenderWidgetHostViewChildFrames. This is useful
314 // to be able to know if this RWHV is embedded within another RWHV. If 314 // to be able to know if this RWHV is embedded within another RWHV. If
315 // other kinds of embeddable RWHVs are created, this should be renamed to 315 // other kinds of embeddable RWHVs are created, this should be renamed to
316 // a more generic term -- in which case, static casts to RWHVChildFrame will 316 // a more generic term -- in which case, static casts to RWHVChildFrame will
317 // need to also be resolved. 317 // need to also be resolved.
318 virtual bool IsRenderWidgetHostViewChildFrame(); 318 virtual bool IsRenderWidgetHostViewChildFrame();
319 319
320 // Notify the View that a screen rect update is being sent to the
321 // RenderWidget. Related platform-specific updates can be sent from here.
322 virtual void OnSendScreenRects() {}
ncarter (slow) 2017/05/30 17:51:09 Optional: "WillSendScreenRects" would be my pick t
kenrb 2017/05/30 18:25:10 That makes sense. Done.
323
320 // Returns true if the current view is in virtual reality mode. 324 // Returns true if the current view is in virtual reality mode.
321 virtual bool IsInVR() const; 325 virtual bool IsInVR() const;
322 326
323 //---------------------------------------------------------------------------- 327 //----------------------------------------------------------------------------
324 // The following methods are related to IME. 328 // The following methods are related to IME.
325 // TODO(ekaramad): Most of the IME methods should not stay virtual after IME 329 // TODO(ekaramad): Most of the IME methods should not stay virtual after IME
326 // is implemented for OOPIF. After fixing IME, mark the corresponding methods 330 // is implemented for OOPIF. After fixing IME, mark the corresponding methods
327 // non-virtual (https://crbug.com/578168). 331 // non-virtual (https://crbug.com/578168).
328 332
329 // Updates the state of the input method attached to the view. 333 // Updates the state of the input method attached to the view.
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
482 base::ObserverList<RenderWidgetHostViewBaseObserver> observers_; 486 base::ObserverList<RenderWidgetHostViewBaseObserver> observers_;
483 487
484 base::WeakPtrFactory<RenderWidgetHostViewBase> weak_factory_; 488 base::WeakPtrFactory<RenderWidgetHostViewBase> weak_factory_;
485 489
486 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewBase); 490 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewBase);
487 }; 491 };
488 492
489 } // namespace content 493 } // namespace content
490 494
491 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 495 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698