Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4525)

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 2910003002: Stability instrumentation: metrics for collection on crash (Closed)
Patch Set: address rkaplow comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_browser_field_trials_desktop.cc ('k') | components/browser_watcher/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/chrome_metrics_service_client.cc
diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc
index 01fb0120fd9ed1111d5076a39d9b19d067c4ca29..37a49f707fe5c1b16c5e7a7b55a47a6d60907e1c 100644
--- a/chrome/browser/metrics/chrome_metrics_service_client.cc
+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc
@@ -13,7 +13,6 @@
#include "base/bind.h"
#include "base/callback.h"
#include "base/command_line.h"
-#include "base/debug/activity_tracker.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/lazy_instance.h"
@@ -423,17 +422,9 @@ void ChromeMetricsServiceClient::OnEnvironmentUpdate(std::string* environment) {
void ChromeMetricsServiceClient::OnLogCleanShutdown() {
#if defined(OS_WIN)
- base::debug::GlobalActivityTracker* global_tracker =
- base::debug::GlobalActivityTracker::Get();
- if (global_tracker)
- global_tracker->MarkDeleted();
-
base::FilePath user_data_dir;
- if (!base::PathService::Get(chrome::DIR_USER_DATA, &user_data_dir)) {
- // TODO(manzagop): add a metric.
- return;
- }
- browser_watcher::MarkStabilityFileForDeletion(user_data_dir);
+ if (base::PathService::Get(chrome::DIR_USER_DATA, &user_data_dir))
+ browser_watcher::MarkOwnStabilityFileDeleted(user_data_dir);
#endif // OS_WIN
}
« no previous file with comments | « chrome/browser/chrome_browser_field_trials_desktop.cc ('k') | components/browser_watcher/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698